[salt-cloud] rackconnect and managedcloud fix#10184
Merged
techhat merged 2 commits intosaltstack:developfrom Feb 4, 2014
Merged
[salt-cloud] rackconnect and managedcloud fix#10184techhat merged 2 commits intosaltstack:developfrom
techhat merged 2 commits intosaltstack:developfrom
Conversation
Everything else should need 0.13.2, but rackconnect will need 0.14.0. Add a function to make custom requirements for libcloud as you would need them.
Rackconnect and ManagedCloud require the extra dict in the node data. I have also added the default options for those because the values are not set immediately.
Contributor
|
Thanks @gtmanfred, waiting for the build to finish. |
|
Test FAILed. |
techhat
added a commit
that referenced
this pull request
Feb 4, 2014
[salt-cloud] rackconnect and managedcloud fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
salt-cloud tries to check .get those values from the nodelist entry. I just added
the default option for each one.
@techhat please take a look.
This also requires libcloud 0.14.0 for the access_ip to be set in the extra dictionary
Fixes #10158
Thanks,
Daniel Wallace