Reuse channels#10298
Conversation
store a cache of the channels so a single pid can re-use a connection this needs to be per pid as when you fork you keep the original memory space and we can't control currency across pids
|
Test FAILed. |
|
Test FAILed. |
|
If you run the tests suite with this changes, you'll notice that this broke it bad. Maybe it needs a different approach? |
|
When I ran it locally i had no test failures, what are you seeing?
|
|
http://jenkins.saltstack.com/job/salt-rs-arch/1623/artifact/salt-runtests.log look at this log, the traceback in it |
|
I'll have to take a look at this.. my first guess would be some problem On Mon, Feb 10, 2014 at 3:40 PM, Pedro Algarvio notifications@github.comwrote:
|
|
If #10325 get's merged, these commits will be reverted. We do need some stability in our tests suite in order to prepare for 2014.1 ... But yes! Please get that feature branch running smoothly, we do want Salt to become more and more performant. Sorry for the troubles... |
|
No worries, sorry about the breakage. Jenkins was messed up when i
|
|
Unable to reproduce locally-- so i've submitted another pull request On Mon, Feb 10, 2014 at 4:16 PM, Thomas Jackson jacksontj.89@gmail.comwrote:
|
|
@basepi let's not cherry-pick this just yet |
3 participants
One of the things i've noticed with a fairly large salt install is that the majority of the master's time seems to be authenticating requests. After some digging it is apparent that we end up creating and destroying zmq channels all over creation. This is an attempt to allow for session re-use. The objective is to re-use the same channel for all requests in a single execution/thread/process-- as having a single long running connection back to the master is a much larger job.