Conversation
Contributor
|
I believe the idea was a shell grain. That way on FreeBSD (for instance) it could default to bash if it is installed and otherwise use ksh, then on Linux default to bash if it is installed. |
Contributor
|
This looks good, I will fix the message thing |
Contributor
Author
|
@thatch45 Were you wanting to add a grain for shell and using that, because I have a patch to add the grain and then partially replace shell defaults with that grain. |
Contributor
|
That would be nice, yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw the disclaimer on the shell the could be used in cmd state and it made me mad and I thought to myself, "Why!?" So I decided to fix it. After looking at the code I was more confused, since the functionality is already there. I added a little bit of logic checking that a specified shell exists and is executable in cmdmod since shells can be defined and I modified the comments so that the generated documentation will reflect that.
Was there a reason that you were saying people where limited to /bin/sh for executing commands?