Support for ssh_known_hosts in modules and states#1315
Merged
thatch45 merged 4 commits intosaltstack:developfrom May 22, 2012
imankulov:ssh_known_hosts
Merged
Support for ssh_known_hosts in modules and states#1315thatch45 merged 4 commits intosaltstack:developfrom imankulov:ssh_known_hosts
thatch45 merged 4 commits intosaltstack:developfrom
imankulov:ssh_known_hosts
Conversation
added 4 commits
May 20, 2012 23:09
- function _validate_keys returns public key fingerprint as described in RFC 4716 - one more test to validate how "ssh.auth_keys" function works
Module "ssh" is now capable of keeping track of records in ssh known_hosts file, as well as asking remote hosts for their public keys.
Contributor
|
Wow, this is awesome! Give me a little time to look over the code, but so far this looks good to me |
Contributor
|
The only thing that is missing is the test interface in the states so that test=True works: |
thatch45
added a commit
that referenced
this pull request
May 22, 2012
Support for ssh_known_hosts in modules and states
Author
|
Oh, you have already merged. I've just added missing code for the test interface. Please consider including imankulov/salt@f20cb3b too. Thank you |
Contributor
|
Heh, I had started to write this myself, I will merge, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider including into the upstream the code to support managing known_hosts files.
It should be mentioned that although these changes are covered somehow by integration tests, the code in fact was never deployed into production (I plan to do it later this week.) Please don't hesitate to comment if you decide to play with it and watch something behaves unexpectedly odd or looks strange. Thank you.