Reuse ZeroMQChannels#13156
Merged
Merged
Conversation
|
Test PASSed. |
Contributor
Author
|
Accidentally force pushed this, i'll update this again from my tower at home |
|
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Contributor
|
I hate it when @github does this, makes it look like I merged something that had no commits from a force push! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the sreq inside the zmqchannel instead of caching the entire channel object.
This is an improvement over #10332 in that you don't have to worry about someone creating a ZeroMQChannel then forking (thereby breaking the per-thread, per-pid rules). This way once it moves it will create a new sreq as needed.