Skip to content

Reuse ZeroMQChannels#13156

Merged
thatch45 merged 0 commit into
saltstack:developfrom
jacksontj:channelreuse
Jun 5, 2014
Merged

Reuse ZeroMQChannels#13156
thatch45 merged 0 commit into
saltstack:developfrom
jacksontj:channelreuse

Conversation

@jacksontj
Copy link
Copy Markdown
Contributor

Cache the sreq inside the zmqchannel instead of caching the entire channel object.

This is an improvement over #10332 in that you don't have to worry about someone creating a ZeroMQChannel then forking (thereby breaking the per-thread, per-pid rules). This way once it moves it will create a new sreq as needed.

@ghost
Copy link
Copy Markdown

ghost commented Jun 1, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4767/

@jacksontj
Copy link
Copy Markdown
Contributor Author

Accidentally force pushed this, i'll update this again from my tower at home

@ghost
Copy link
Copy Markdown

ghost commented Jun 5, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4901/

@thatch45 thatch45 merged commit ae9b62c into saltstack:develop Jun 5, 2014
@thatch45
Copy link
Copy Markdown
Contributor

thatch45 commented Jun 5, 2014

I hate it when @github does this, makes it look like I merged something that had no commits from a force push!

@jacksontj jacksontj mentioned this pull request Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants