OpenBSD: service.enable needs python_shell=true

[ajacoutot]

That's because it uses the double ampersand to combine commands.

[thatch45]

@jfindlay please take a look at doing this in a more elegant way since we don't want to use a shell=True here

[ajacoutot]

Hi. I am the developer of the rcctl(1) utility, I can try and find a better way to achieve the same if needed.

[jfindlay]

@ajacoutot, how do you feel about #25216? One other issue is that the introduction of the && is also in the 2015.8 branch, so I've submitted that pull request there.

[jfindlay]

Also the issue with using python_shell=True in execution modules is that this can expose salt to shell injection vulnerabilities in some circumstances.

[ajacoutot]

@jfindlay #25216 is definitely the way to go, thanks a lot.
Successfully tested here.

[rallytime]

Thanks for confirming @ajacoutot. I am going to close this pull request in favor of #25216 so this one doesn't get accidentally merged. Thanks!

[jfindlay]

Thanks, @ajacoutot.