Add '*' case to api_acl.#26083
Merged
whiteinge merged 1 commit intosaltstack:developfrom Aug 7, 2015
TheScriptSage:develop
Merged
Add '*' case to api_acl.#26083whiteinge merged 1 commit intosaltstack:developfrom TheScriptSage:develop
whiteinge merged 1 commit intosaltstack:developfrom
TheScriptSage:develop
Conversation
Author
|
Tests look unrelated. Will wait til you guys get back to me. Thanks. |
Contributor
|
Failures are unrelated. Thanks for the udpate. |
Author
|
Hey, can this possibly make it into 2015.8? (The api_acl and the change), I see it's in develop but we want to cut a release internally and want to use it. Thanks either way! |
Contributor
|
@TheScriptSage the addition is safely config-gated so I'm good with it. If you open the pull req against 2015.8 I will sneak it in. |
jfindlay
added
Core
Author
|
@whiteinge - See #26279. I hope I did this right, I'd like to look into getting this merged. :D Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks.
In #25632 I added the api acl option, though we realized we also need a default case ('*'), so It's been added.
Should be a relatively minor change, I'll see what the tests say.