cherry-picking of smartos virt and vmadm module#26770
Merged
basepi merged 33 commits intosaltstack:developfrom Sep 1, 2015
sjorge:vmadm-develop
Merged
cherry-picking of smartos virt and vmadm module#26770basepi merged 33 commits intosaltstack:developfrom sjorge:vmadm-develop
basepi merged 33 commits intosaltstack:developfrom
sjorge:vmadm-develop
Conversation
….py (virtual=virt)
…utput UUID of created vm
Contributor
Author
|
Test fail doesn't look like it is code related? |
This was referenced Aug 29, 2015
jfindlay
added
Master Change
Platform
basepi
added a commit
that referenced
this pull request
Sep 1, 2015
cherry-picking of smartos virt and vmadm module
Contributor
|
@sjorge, thanks cleaning this up. That was my plans, although yet I was unable to find a free hardware for SmartOS to finish this, and this OS does not like to run on a VM... 😢 Thanks a lot! |
Contributor
Author
|
@isbm newish (last month?) platform iso/images for smartos now vioblk and vioif drivers. So they should work pretty OK under qemu-kvm (vmware is likewise pretty OK). Once I am back from my trip I'll probably make smartos_virt.py do calls to the vmadm replacement internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry picked branch of PR #26733 for develop.
note: I will now mention virtual names instead of file names for clarity
With the 'virt' module that is now more or less inline with 'virt' for other platforms closing issue #26507 for develop branch. One more PR will follow later today to do the same for 2015.8 branch.
I may revisit 'virt' module for a bit more cleanup after my trip.