Merged
Conversation
- grains.item and grains.list are now shorter
- grains.item can be called without an argument and won't barf
It overrides a python builtin
- Add outputters for dig and netstat
- Remove a pointless check from network.netstat()
- The network module doesn't work in Ubuntu 10.10
- The traceroute module doesn't work in Ubuntu 10.10
For cron.list_jobs and cron.rm_tab. This just keeps things a bit consistent and more obvious to any 'nix geek who happenst to look
Previously, disk.usage was returning a dictionary where the key was in the "Filesystem" column. It seemed proper to return every filesystem, even the virtual ones so the dict key was changed to the mountpoint. $ df -P Filesystem 1024-blocks Used Available Capacity Mounted on /dev/sda8 177822980 12504764 156285272 8% / none 6154104 312 6153792 1% /dev none 6161372 3736 6157636 1% /dev/shm none 6161372 336 6161036 1% /var/run none 6161372 0 6161372 0% /var/lock /dev/sda1 101086 85423 15663 85% /boot /dev/sda5 240308484 219822840 20485644 92% /home /dev/sda7 54791132 1104204 50903672 3% /var This can be changed to skip anything that has a Filesystem of none down the road, but I don't have any non-Linux hosts to test on.
As part of this branch, I'm trying to read through most all of the modules and clean things up. This is small, and might not normally warrant a commit, but I'm trying to keep things easy to bisect.
- Add apache.signal text outputter
- Add the following signals: status, fullstatus, configtest
- Lots of style cleanups to fit better with the rest of salt
- Output information about what happened when signals are ran
This patch is a function noop, but makes the code easier to read
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jun 25, 2021
twangboy
pushed a commit
to twangboy/salt
that referenced
this pull request
Apr 20, 2022
[3002.9] Update the ftp url in the cp tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has a bunch of cleanups for personal coding style nits, some pep8, fixing bugs, and adding features. I've not had time to go over each and every module just yet or finish everything. However, this would be a pain to rebase if it starts getting merge conflicts so upstream ahoy!
PLEASE SCRUTINIZE THIS PATCH SERIES - it touches a lot of code
A few more cleanups that will come at a later time