Merged
Conversation
Contributor
|
Hi @alexbleotu There are some lint violations on this change as well: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/6421/violations/ Thanks for writing tests! |
rallytime
added
the
pending-changes
added 2 commits
October 31, 2016 12:46
- updates an existing cluster based on a configuration spec
alexbleotu
force-pushed
the
update_cluster-gh
branch
from
ccbfa3f to
71fbabd
Compare
Contributor
Author
|
any further issues? |
Contributor
|
Nope! Thanks @alexbleotu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added utils.vmware.update_cluster
Tests written?
Yes
Please review Salt's Contributing Guide for best practices.