Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use sls_build for building docker images #39467
What does this PR do?
Allows the use of
Also fix some bad logic with clearing out the created docker containers after a build was finished. Without the reorganization around the dryrun check, we would leave behind the container that was used to create the image. The logic is fixed here. 5eed60b?diff=split#diff-8f4981346bb8d093255737c1cd281ef6R5986
Ugh, the test suite hates me! I thought I got them all yesterday when it failed >.< I will look at them when I get off the plane in Denver, thanks!…
On Fri, Feb 17, 2017 at 12:17 PM Mike Place ***@***.***> wrote: @gtmanfred <https://github.com/gtmanfred> We have some test failures here: https://jenkins.saltstack.com/job/PR/job/salt-pr-rs-cent7-n/8839/testReport/junit/unit.modules.dockerng_test/DockerngTestCase/test_sls_build/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39467 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAssoTW1kJFrKpMiBAFvHeC5yrzOdWvcks5rdeQ-gaJpZM4MDqNP> .