Fix: decrease loglevel when unable to resolve addr#46575
Merged
Conversation
It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error.
Some examples:
```
caasp-admin:~ # uptime
09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98
caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l
528
```
```
caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime
b24f41eb4cc94624862ca0c9e8afcd15:
09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40
admin:
09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99
ba8c76af029043a39ba917f7ab2af796:
09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32
7b7aa52158524556a0c46ae57569ce93:
09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38
5ab0e18cbd084e9088a928a17edb86cb:
09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20
1756c9cd9a9a402b91d8636400d1e512:
09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14
ca:
09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99
caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'"
admin:
63
ba8c76af029043a39ba917f7ab2af796:
47
5ab0e18cbd084e9088a928a17edb86cb:
55
7b7aa52158524556a0c46ae57569ce93:
59
b24f41eb4cc94624862ca0c9e8afcd15:
47
1756c9cd9a9a402b91d8636400d1e512:
59
ca:
25
```
This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
Contributor
|
re-run all |
rallytime
approved these changes
Mar 20, 2018
This was referenced Mar 20, 2018
brejoc
pushed a commit
to openSUSE/salt
that referenced
this pull request
Mar 21, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
dincamihai
pushed a commit
to openSUSE/salt
that referenced
this pull request
Mar 21, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
isbm
reviewed
Mar 21, 2018
| except (socket.error, socket.herror, | ||
| socket.gaierror, socket.timeout) as e: | ||
| log.error("Exception during resolving address: " + str(e)) | ||
| log.info("Exception during resolving address: " + str(e)) |
Contributor
There was a problem hiding this comment.
@rallytime but this seems to me a wrong fix:
- It sets
.infoafter the exception. - It uses concatenation instead of formatting through the Unicode
Proper fix would be to move this to a debug level and use proper formatting:
except (socket.error, socket.herror, socket.gaierror, socket.timeout) as err:
log.debug('Exception during resolving address: %s', err)
except Exception as err:
log.exception(err)
dincamihai
pushed a commit
to openSUSE/salt
that referenced
this pull request
Mar 23, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
dincamihai
pushed a commit
to openSUSE/salt
that referenced
this pull request
Mar 23, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
mcalmer
pushed a commit
to openSUSE/salt
that referenced
this pull request
Mar 28, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
dincamihai
pushed a commit
to openSUSE/salt
that referenced
this pull request
Apr 4, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
dincamihai
pushed a commit
to openSUSE/salt
that referenced
this pull request
Apr 6, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
meaksh
pushed a commit
to openSUSE/salt
that referenced
this pull request
Jun 14, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
brejoc
pushed a commit
to openSUSE/salt
that referenced
this pull request
Jul 3, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
meaksh
pushed a commit
to openSUSE/salt
that referenced
this pull request
Oct 26, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
meaksh
pushed a commit
to openSUSE/salt
that referenced
this pull request
Oct 26, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
meaksh
pushed a commit
to openSUSE/salt
that referenced
this pull request
Oct 29, 2018
Upstream PR: saltstack/salt#46575 It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error. Some examples: ``` caasp-admin:~ # uptime 09:08am up 0:13, 2 users, load average: 1.30, 1.37, 0.98 caasp-admin:~ # docker logs $(docker ps | grep salt-master | awk '{print $1}') 2>&1 | grep "Exception during resolving address" | wc -l 528 ``` ``` caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run uptime b24f41eb4cc94624862ca0c9e8afcd15: 09:08am up 0:11, 0 users, load average: 1.26, 0.83, 0.40 admin: 09:08am up 0:13, 2 users, load average: 1.33, 1.37, 0.99 ba8c76af029043a39ba917f7ab2af796: 09:08am up 0:12, 0 users, load average: 0.84, 0.63, 0.32 7b7aa52158524556a0c46ae57569ce93: 09:08am up 0:11, 1 user, load average: 1.05, 0.77, 0.38 5ab0e18cbd084e9088a928a17edb86cb: 09:08am up 0:10, 0 users, load average: 0.12, 0.25, 0.20 1756c9cd9a9a402b91d8636400d1e512: 09:08am up 0:09, 0 users, load average: 0.12, 0.23, 0.14 ca: 09:08am up 0:13, 0 users, load average: 1.33, 1.37, 0.99 caasp-admin:~ # docker exec -it $(docker ps | grep salt-master | awk '{print $1}') salt '*' cmd.run "bash -c 'cat /var/log/salt/minion | grep \"Exception during resolving address\" | wc -l'" admin: 63 ba8c76af029043a39ba917f7ab2af796: 47 5ab0e18cbd084e9088a928a17edb86cb: 55 7b7aa52158524556a0c46ae57569ce93: 59 b24f41eb4cc94624862ca0c9e8afcd15: 47 1756c9cd9a9a402b91d8636400d1e512: 59 ca: 25 ``` This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It occurs that when the machine has multiple interfaces without an associated FQDN, Salt logs are polluted by this error.
Some examples:
This patch changes the log level of the exception to INFO, since the resolve-unable problem is not blocking.
What issues does this PR fix or reference?
Logs "spamming"
Previous Behavior
Logging with log level = ERROR
New Behavior
Logging with log level = INFO
Tests written?
No, just a change of log level
Commits signed with GPG?
No