Fix libvirt_events engine running on master#46928
Merged
Merged
Conversation
cachedout
suggested changes
Apr 6, 2018
Contributor
cachedout
left a comment
cachedout
left a comment
There was a problem hiding this comment.
Tiny grammatical change. The rest looks great!
Parameters order is different when firing events on master or minion. The order for master was wrong. Also added documentation on how to setup polkit to run the engine on a master node.
cbosdo
force-pushed
the
libvirt-events-fix
branch
from
4013ecd to
4ca6f2c
Compare
Contributor
Author
|
Fixed the |
cachedout
approved these changes
Apr 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parameters order is different when firing events on master or minion.
The order for master was wrong. Also added documentation on how to setup
polkit to run the engine on a master node.
What issues does this PR fix or reference?
None reported
Previous Behavior
Error when firing libvirt events when running on master node
New Behavior
Libvirt events sent on master node as well
Tests written?
No - trivial fix
Commits signed with GPG?
Yes