libvirt_events, harmonize object descriptions#46957
Merged
Merged
Conversation
Use a dictionary to describe all events objects (domain, network, pool, nodedev and secret). This allows future extensions of the data describing these objects. Also make sure to provide the object UUID where one exists since some client applications use them to identify objects.
Domain lifecycle event was not using the callback provided event type for the tag, but rather using the realy event. Harmonize this with the other callbacks
rallytime
approved these changes
Apr 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use a dictionary to describe all events objects (domain, network, pool,
nodedev and secret). This allows future extensions of the data
describing these objects.
Also make sure to provide the object UUID where one exists since some
client applications use them to identify objects.
What issues does this PR fix or reference?
No issue referenced. While writing client code listening for the events, I realized that some infos may be missing in the events, like UUIDs (and may be nodedev parent)
Previous Behavior
Events for domain, network and pool objects didn't include the object UUID
New Behavior
These events data now include UUIDs and are using JSON objects to allow more extensibility
Tests written?
No, just minor data changes
Commits signed with GPG?
Yes