Log error when reactor tasks go to a full queue#48775
Conversation
terminalmage
left a comment
terminalmage
left a comment
There was a problem hiding this comment.
One minor change needed in the logging.
|
|
||
| if ret is False: | ||
| log.error('Reactor \'%s\' failed to execute %s \'%s\': ' | ||
| 'TaskPool queue is full!' |
There was a problem hiding this comment.
There is no space between this sentence and the next. A space should be added before Consider.
There was a problem hiding this comment.
I'm not sure I totally follow the logic of this. This looks more to me like it's evaluating the return from the wrapped function call itself where False could be a totally legitimiate value. What am I missing here?
There was a problem hiding this comment.
Sure, from what I can see, False is only returned when the queue is full. As per current behavior, we will right now silently fail to insert something on the queue. The only behavior I am adding is a log message when the queue is full. Otherwise, continue as per today.
6 participants
Fixes #46431
What does this PR do?
Check return values of fire_async, the only possible return of False is if queue is full.
What issues does this PR fix or reference?
46431
Previous Behavior
Silently ignore failure to inject a task into a full queue
New Behavior
Only adds a log message
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.