create ssh_auth.manage#50141
Merged
cachedout merged 3 commits intosaltstack:developfrom Oct 22, 2018
Merged
Conversation
cachedout
approved these changes
Oct 22, 2018
Closed
This was referenced Mar 15, 2019
mchugh19
pushed a commit
to mchugh19/salt
that referenced
this pull request
Oct 12, 2019
create ssh_auth.manage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replacement for #49776
Creates a new ssh_auth.manage state to be used to both add and remove ssh keys
What issues does this PR fix or reference?
#13340
#18252
Previous Behavior
ssh_auth.present was only able to add keys. Any old keys not managed by salt need to be removed by specifying them in a ssh_auth.absent state.
New Behavior
By using ssh_auth.manage, ssh keys not added by salt will be removed.
state example
add key result
remove key result
add with test
Tests written?
No
Commits signed with GPG?
No