add underscore to sanitize_host accepted char set#50527
Merged
Conversation
its a valid hostname character
twangboy
pushed a commit
to twangboy/salt
that referenced
this pull request
Sep 30, 2020
add underscore to sanitize_host accepted char set
dwoz
pushed a commit
that referenced
this pull request
Oct 1, 2020
add underscore to sanitize_host accepted char set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
its a valid hostname character
What issues does this PR fix or reference?
n/a
Previous Behavior
foo_bar hostname in network.ping would get truncated to foobar
New Behavior
foo_bar remains intact
Tests written?
No
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.