Skip to content

[Fluorine] Unify salt-call/salt executor arguments#50974

Merged
Ch3LL merged 2 commits intosaltstack:2019.2.0.rc1from
max-arnold:salt-call-executor-options
Jan 25, 2019
Merged

[Fluorine] Unify salt-call/salt executor arguments#50974
Ch3LL merged 2 commits intosaltstack:2019.2.0.rc1from
max-arnold:salt-call-executor-options

Conversation

@max-arnold
Copy link
Copy Markdown
Contributor

@max-arnold max-arnold commented Dec 24, 2018

#48344 adds --module-executors and --executor-opts arguments to salt-call. Unfortunately, the first one does not support lists (as it does in salt command):

% salt-call --local --module-executors='[direct_call, direct_call]' test.ping

Passed invalid arguments: Executor '[direct_call, direct_call]' is not available.

% salt MINION --module-executors='[direct_call, direct_call]' test.ping
MINION:
    True

And the second one seems to be ignored completely.

New Behavior

This patch allows to specify these CLI arguments for salt-call in the same way as for salt.

% salt-call --local -l debug --module-executors='[splay, direct_call]' --executor-opts='{splaytime: 100}' test.ping 2>&1 | grep Splay
[DEBUG   ] Splay is sleeping 2 secs on test.ping

Tests written?

No

Commits signed with GPG?

No

@max-arnold max-arnold requested a review from a team as a code owner December 24, 2018 04:58
@max-arnold
Copy link
Copy Markdown
Contributor Author

P.S. salt-ssh too should support these arguments (for consistency and better UX), but I haven't figured out how to add them.

@Ch3LL Ch3LL changed the base branch from fluorine to 2019.2 January 7, 2019 19:37
@max-arnold
Copy link
Copy Markdown
Contributor Author

@Ch3LL Hi! Any chance of this to get merged into Fluorine?

@terminalmage
Copy link
Copy Markdown
Contributor

Since this was opened well after the feature freeze, I don't think so. It should be re-opened against develop.

@max-arnold
Copy link
Copy Markdown
Contributor Author

@terminalmage This is a fix against a feature that went into Fluorine

@terminalmage
Copy link
Copy Markdown
Contributor

Ahh, OK. @Ch3LL should this be opened against the RC branch then?

@Ch3LL
Copy link
Copy Markdown
Contributor

Ch3LL commented Jan 18, 2019

yes if it needs to be in for 2019.2.0. If not this will get in for 2019.2.1

@max-arnold max-arnold changed the base branch from 2019.2 to 2019.2.0.rc1 January 20, 2019 04:22
@Ch3LL Ch3LL merged commit c118387 into saltstack:2019.2.0.rc1 Jan 25, 2019
@max-arnold max-arnold deleted the salt-call-executor-options branch January 30, 2019 11:43
@max-arnold max-arnold mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants