[Fluorine] Unify salt-call/salt executor arguments#50974
Merged
Ch3LL merged 2 commits intosaltstack:2019.2.0.rc1from Jan 25, 2019
Merged
[Fluorine] Unify salt-call/salt executor arguments#50974Ch3LL merged 2 commits intosaltstack:2019.2.0.rc1from
Ch3LL merged 2 commits intosaltstack:2019.2.0.rc1from
Conversation
Contributor
Author
|
P.S. |
Contributor
Author
|
@Ch3LL Hi! Any chance of this to get merged into Fluorine? |
Contributor
|
Since this was opened well after the feature freeze, I don't think so. It should be re-opened against develop. |
Contributor
Author
|
@terminalmage This is a fix against a feature that went into Fluorine |
Contributor
|
Ahh, OK. @Ch3LL should this be opened against the RC branch then? |
Contributor
|
yes if it needs to be in for 2019.2.0. If not this will get in for 2019.2.1 |
Ch3LL
approved these changes
Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48344 adds
--module-executorsand--executor-optsarguments tosalt-call. Unfortunately, the first one does not support lists (as it does insaltcommand):And the second one seems to be ignored completely.
New Behavior
This patch allows to specify these CLI arguments for
salt-callin the same way as forsalt.Tests written?
No
Commits signed with GPG?
No