Skip to content

Add list target type support to the scan roster.#52700

Closed
DmitryKuzmenko wants to merge 7 commits intosaltstack:developfrom
DSRCorporation:features/roster_scan_list
Closed

Add list target type support to the scan roster.#52700
DmitryKuzmenko wants to merge 7 commits intosaltstack:developfrom
DSRCorporation:features/roster_scan_list

Conversation

@DmitryKuzmenko
Copy link
Copy Markdown
Contributor

What does this PR do?

A small change for scan roster type to make salt-ssh able to address a list of minions.

What issues does this PR fix or reference?

Fixes #52675

Previous Behavior

The tgt_type argument was ignored in the scan roster implementation.

New Behavior

If tgt_type is list (-L command line argument) the target treated as a list of addresses. In other cases works as before. Now it's possible to address a list as the following:

$ ./scripts/salt-ssh --user=dimm --priv=/home/dimm/.ssh/id_rsa --roster=scan -L '127.0.0.1,127.0.0.2' test.ping
127.0.0.1:
    True
127.0.0.2:
    True

Tests written?

No

Commits signed with GPG?

Yes

Copy link
Copy Markdown
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DmitryKuzmenko Are there tests for this?

@DmitryKuzmenko
Copy link
Copy Markdown
Contributor Author

DmitryKuzmenko commented Apr 29, 2019

There is no any test for the scan roster at all. I've made this change just because to make it was faster than describing why it's not working. I'll look what can I do about a test.

@DmitryKuzmenko
Copy link
Copy Markdown
Contributor Author

@dwoz test is here. Could you please re-review this?

@sagetherage sagetherage added the develop Pointing to develop branch; needs rebase label May 23, 2020
@sagetherage sagetherage added this to the Blocked milestone May 26, 2020
@DmitryKuzmenko DmitryKuzmenko added the has master-port port to master has been created label Jun 25, 2020
@DmitryKuzmenko DmitryKuzmenko deleted the features/roster_scan_list branch October 23, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

develop Pointing to develop branch; needs rebase has master-port port to master has been created Reviewers-Assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

salt-ssh roster scan multiple minions

5 participants