Add list target type support to the scan roster.#52700
Closed
DmitryKuzmenko wants to merge 7 commits intosaltstack:developfrom
Closed
Add list target type support to the scan roster.#52700DmitryKuzmenko wants to merge 7 commits intosaltstack:developfrom
scan roster.#52700DmitryKuzmenko wants to merge 7 commits intosaltstack:developfrom
Conversation
dwoz
reviewed
Apr 26, 2019
Contributor
dwoz
left a comment
There was a problem hiding this comment.
@DmitryKuzmenko Are there tests for this?
Contributor
Author
|
There is no any test for the |
Contributor
Author
|
@dwoz test is here. Could you please re-review this? |
Akm0d
approved these changes
Jun 19, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A small change for
scanroster type to makesalt-sshable to address a list of minions.What issues does this PR fix or reference?
Fixes #52675
Previous Behavior
The
tgt_typeargument was ignored in thescanroster implementation.New Behavior
If
tgt_typeis list (-Lcommand line argument) the target treated as a list of addresses. In other cases works as before. Now it's possible to address a list as the following:Tests written?
No
Commits signed with GPG?
Yes