Acme state fixup 2019.2#54007
Conversation
ghost
requested a review
from 
|
Requires #52455. Should I create a PR for that for the 2019.2 branch? |
|
I don't know what to do to fix the currently failing tests. Tests either fail because of |
|
Hey @github-abcde thanks for the PR! We're currently focusing on getting our test suites stable - we've got some tech debt around our test infrastructure that we're in the process of paying down. If you're OK with waiting, it's fine to wait until we get this flakiness resolved. Or you can also feel free to investigate any of the flakiness :) Our current focus is on the 2019.2.1 branch, as we're trying to get that released. Once we've got our pipeline stable it should significantly improve our PR process. |
…w" parameter in "needs_renewal". Pylint-inspired layout fixes.
…ction if nothing/fetch/renew is needed to be done.
…509.read_certificate as alternative method of getting certificate information if tls.cert_info is not available.
…o using x509.read_certificates. Fixed incorrect data placement in textwrap.dedent. Updated test for acme.info to expect dict when using openssl cli.
…function docstrings.
…tools More dictupdate tools
github-abcde
force-pushed
the
acme_state_fixup-2019.2
branch
from
6cd9e61 to
77efe38
Compare
|
Closing this in favor of #55589 |
3 participants
What does this PR do?
(2019.2 version of #53366)
It provides an alternative to
loop.untilthat does not useeval.Added example for using this in the faq. Made some pylint-inspired changes.
I'm not entirely sure that the name of the new state
until_no_evalis good enough (even though it is accurate), since it feels wrong to name a function with something that it does not have. I'm open to suggestions on this.What issues does this PR fix or reference?
None
Previous Behavior
The generic state that allows you to (blockingly) execute a salt function until it produces a desired output hinged on using
evalwith user-input. Since this is potentially very dangerous, an alternative has been supplied.New Behavior
A state exists (
loop.until_no_eval) that will block execution until a specific salt execution module function returns an expected result. This produced result is passed together with the expected result to a function (either a method of python'soperator, a function from__salt__or__utils__) to produce a boolean indicating success (or failure).Additionally, a parameter
init_waitis available to configure a waiting period before the 1st call of the salt function is made.Tests written?
Yes
Commits signed with GPG?
Yes