adds webconfig tests#54069
Merged
Merged
Conversation
ghost
requested a review
from 
Akm0d
approved these changes
Jul 30, 2019
twangboy
approved these changes
Jul 30, 2019
Ch3LL
reviewed
Jul 31, 2019
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
I'm not sure how possible it is, but would it be easy to add some integration tests here as well?
dwoz
approved these changes
Aug 23, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds tests
What issues does this PR fix or reference?
https://github.com/saltstack/zh/issues/1454
Tests written?
Yes
Commits signed with GPG?
Yes