Fix cmd.run preconditions failing if cwd does not exist#55066
Closed
timbasel wants to merge 7 commits intosaltstack:masterfrom
timbasel:fix_cmd.run_precondition_cwd
Closed
Fix cmd.run preconditions failing if cwd does not exist#55066timbasel wants to merge 7 commits intosaltstack:masterfrom timbasel:fix_cmd.run_precondition_cwd
timbasel wants to merge 7 commits intosaltstack:masterfrom
timbasel:fix_cmd.run_precondition_cwd
Conversation
ghost
requested a review
from 
dwoz
added
the
needs-testcase
sagetherage
added
bug
Contributor
|
@timbasel Thanks for the PR. A recent change has pulled out the requisite code in individual state modules in favor of using the system wide requisites in the state system, making this change redundant. The original issue also seems to not longer be present, so I'm going to close this one out. Thanks again. |
Contributor
|
here is the original PR that removed the requisite code: #55974 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a check to precondition execution that set cwd to default if either not absolute or does not exist
What issues does this PR fix or reference?
Fix #45039
Tests written?
No
Question
Should this pull request be expanded to also check if the provided user in
runasexists?