Fixes AzureRM create_object_model util#56379
Merged
Ch3LL merged 8 commits intosaltstack:masterfrom Apr 15, 2020
Ajnbro:fix-create-object
Merged
Fixes AzureRM create_object_model util#56379Ch3LL merged 8 commits intosaltstack:masterfrom Ajnbro:fix-create-object
Ch3LL merged 8 commits intosaltstack:masterfrom
Ajnbro:fix-create-object
Conversation
ghost
requested a review
from 
Ch3LL
suggested changes
Mar 16, 2020
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
can we get some tests added here? and can you create an issue with details of the issue and tie it to this PR, to make it easier for others running into the issue to see it.
Ch3LL
added
the
needs-testcase
Contributor
|
@Ch3LL test case added. This issue was actually something that we ran into in Idem, but also could apply to Salt... we just don't have any concrete errors to report. |
Ch3LL
previously approved these changes
Mar 18, 2020
Ch3LL
added
Merge Ready
and removed
needs-testcase
Contributor
|
Merge conflicts need to be resolved. |
Ch3LL
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the Microsoft Azure Resource Manager create_object_model util. Currently, the util is not properly building some object models. The issue is caused by the util improperly handling the existence of parameters because it does not account for the existence of parameters that are set as Boolean values (specially False).
What issues does this PR fix or reference?
N/A
Previous Behavior
Object models with parameters that may have contained Boolean values (specially False) were being built improperly.
New Behavior
Object models with parameters that may contain Boolean values (specially False) are being built properly.
Tests written?
No
Commits signed with GPG?
Yes