Master fix aptpkg systemd call#56396
Merged
Merged
Conversation
ghost
requested a review
from 
Contributor
Author
|
This PR replaces #54077. |
cmcmarrow
previously approved these changes
Mar 23, 2020
Contributor
Author
|
I've just merged master again. Anything else that needs to be done? |
DmitryKuzmenko
previously approved these changes
Apr 2, 2020
Contributor
|
@brejoc you're okay. I've just re-started the test suite. Let's wait for results. |
Contributor
|
@brejoc could you please resolve merge conflicts? |
Contributor
Author
|
@DmitryKuzmenko PR now complies with black formatting. |
DmitryKuzmenko
approved these changes
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets a
--descriptionfor the systemd-run command called by aptpkg to avoid long description strings that would cause crashes.The description comes from
__name__and it would besalt.modules.aptpkgWhat issues does this PR fix or reference?
Fixes: aptpkg module causes systemd to crash in Ubuntu 18.04.
When no description is provided to systemd-run, the description is autogenerated from the apt-get command.
If we have a long list of packages the description will be longer than what systemd-run supports and it will crash (systemd/systemd@a7419db)
Setting the description ourselves prevents this even if the systemd doesn't have the fix.
Previous Behavior
See above
New Behavior
Sets the description to
salt.modules.aptpkgTests written?
Yes