Fix typo on msgpack version when sanitizing msgpack kwargs #56463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a typo when sanitizing the kwargs that are passed to
msgpack. Particularly, therawparameter is introduced on version0.5.2and not in0.5.5. This typo is clashing with https://github.com/saltstack/salt/blob/master/salt/payload.py#L108 so, in case you're running with i.a. msgpack version 0.5.4, this conflict will lead you to some problems when managing thefile_listfileserver cache.One collateral effect of this, is
file.recursestate not working.Example using msgpack 0.5.4:
With version 0.5.6 (or with the changes from this PR):
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes/No
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.