Skip to content

The SSH API supports multiple IPs#57937

Closed
frieda1220 wants to merge 2 commits intosaltstack:masterfrom
frieda1220:master
Closed

The SSH API supports multiple IPs#57937
frieda1220 wants to merge 2 commits intosaltstack:masterfrom
frieda1220:master

Conversation

@frieda1220
Copy link
Copy Markdown

What does this PR do?

What issues does this PR fix or reference?

Fixes:

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@frieda1220 frieda1220 requested a review from a team as a code owner July 14, 2020 10:31
@ghost ghost requested review from DmitryKuzmenko and removed request for a team July 14, 2020 10:31
@DmitryKuzmenko
Copy link
Copy Markdown
Contributor

DmitryKuzmenko commented Jul 14, 2020

@frieda1220 Thank you for contribution!
This PR is duplicate of #57799. Could you please review it and provide your opinion?

@frieda1220
Copy link
Copy Markdown
Author

We do the same thing, I have less code.

@DmitryKuzmenko
Copy link
Copy Markdown
Contributor

@frieda1220 Yep, thank you for pointing this out, I've found that putting all the code inside the loop for target list is redundant. I've updated my code. So now it contains your good approach.

@dwoz dwoz added the needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 27, 2020
@sagetherage sagetherage requested review from Ch3LL and removed request for DmitryKuzmenko November 18, 2020 18:42
@sagetherage sagetherage added the merge-conflict PR has a merge conflict label Nov 18, 2020
@Ch3LL
Copy link
Copy Markdown
Contributor

Ch3LL commented Dec 4, 2020

closing as a duplicate of #57799

@Ch3LL Ch3LL closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-failing-test merge-conflict PR has a merge conflict needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants