[merge jam] port 48447 - Fix manage.down crash#58057
Closed
waynew wants to merge 2 commits intosaltstack:masterfrom
Closed
[merge jam] port 48447 - Fix manage.down crash#58057waynew wants to merge 2 commits intosaltstack:masterfrom
waynew wants to merge 2 commits intosaltstack:masterfrom
Conversation
Contributor
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port #48447
Note: I'm not sure if this PR is actually necessary. The original complaint was that we get this error:
But that's not what we see currently. We get
Which is more worthwhile and actually says something. I'm inclined to say we may not need this port, especially since there was no original issue, just the PR.