Refactor tests/unit/states/test_sysctl.py

[asomers]

What does this PR do?

The old test combined several different independent commands into a
single obese test case, with overlapping local variables.

Break it into small individual test cases. Also, fix some of the mocks,
which only triggered correct behavior by coincidence.

Merge requirements satisfied?

• [N/A] Docs
• [N/A] Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

[asomers]

Thanks @krionbsd . Although, I already had such a commit ready to go. In the future, should I force-push stylistic fixes ASAP rather than wait for the tests to finish?

[krionbsd]

Thanks @krionbsd . Although, I already had such a commit ready to go. In the future, should I force-push stylistic fixes ASAP rather than wait for the tests to finish?

Yeah, that would make sense to reduce total CI run/time

[asomers]

And @krionbsd do you prefer that I push style fixes as separate commits, or that I amend the original commit and force-push?

[krionbsd]

And @krionbsd do you prefer that I push style fixes as separate commits, or that I amend the original commit and force-push?

@asomers I think amending the original commit and force-push is ok

[asomers]

The test failure in ci/py3/ubuntu1604/m2crypto is definitely unrelated to this PR, because this PR only affects tests in a different file.

[asomers]

Again ci/py3/ubuntu1604/m2crypto failed for the exact same reason. @krionbsd do you have any idea why?

[krionbsd]

Again ci/py3/ubuntu1604/m2crypto failed for the exact same reason. @krionbsd do you have any idea why?

That's a magic :)

[asomers]

Rebased and squashed

[asomers]

The most recent build failure looks unrelated to this PR.