Add ssl argument to Mongo connection#59927
Add ssl argument to Mongo connection#59927dwoz merged 19 commits intosaltstack:masterfrom babs:mongodb-ssl-arg
Conversation
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
I really like this addition, for obvious reasons 😄
We do require test coverage for code that's changed, and we don't really have that here. Is that something that you'd be wiling to add?
If not, no big deal - we'll just add the help-wanted label and will be able to merge when we can write tests for it.
Also this will need a changelog entry
|
I'll have to call for help on that :/ |
|
I went ahead and implemented the changes+tests. Just re-merged the latest changes from master in, so 🤞 hopefully all the tests pass now. |
|
@waynew done :) |
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
|
It's still relevant unless another PR has been merged that adds ssl to mongodb... |
|
@babs Please rebase and fix the conflicts. |
|
@waynew might need a second pair of eyes and possibly hands to check the rebase :) |
|
@waynew might need your help on mongo ssl tests |
|
@dwoz do you know somebody that could give me a hand on fixing the instace tests ? |
|
@dwoz do you know somebody that could give me a hand on fixing the instance tests ? |
These tests are not *super* meaningful but they do at least ensure that ssl the arg correctly gets passed into the MongoClient. Still left to do is add tests + ssl arg for the mongodb_database state, the mongodb module, as well as updating all of the documentation for these modules. We also want to add a few functional tests that ensure that the SSL argument is correctly used with an actual mongodb server.
... as well as the necessary modules, natch.
Would still like to add functional tests against an actual mongodb.
Without verify_ssl it's a bit complicated to test, and if someone wants to use self-signed certs in their environment without actually installing the certs or making a CA, that should also be up to them.
4 participants
What does this PR do?
Add ssl argument to Mongo connection