Fix version part of osfinger on Pop!_OS#61619
Merged
garethgreenaway merged 2 commits intosaltstack:masterfrom Sep 30, 2022
Merged
Fix version part of osfinger on Pop!_OS#61619garethgreenaway merged 2 commits intosaltstack:masterfrom
garethgreenaway merged 2 commits intosaltstack:masterfrom
Conversation
bdrung
force-pushed
the
fix-pop-osfinger
branch
3 times, most recently
from
c141d16 to
7454f25
Compare
bdrung
force-pushed
the
fix-pop-osfinger
branch
from
7454f25 to
41ca0af
Compare
Update the OS grains test cases for Pop!_OS to still supported versions. Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
Pop!_OS uses the same version scheme than Ubuntu (YY.MM) and releases every six month in April and October. Using only the year from the version in the `osfinger` does not allow differentiating between 20.04 and 20.10. Both has the `osfinger` set to `Pop-20`. So include the full version in the `osfinger` grain. Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
bdrung
force-pushed
the
fix-pop-osfinger
branch
from
41ca0af to
b0baef0
Compare
garethgreenaway
approved these changes
Sep 30, 2022
dmurphy18
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pop!_OS uses the same version scheme than Ubuntu (YY.MM) and releases every six month in April and October. Using only the year from the version in the
osfingerdoes not allow differentiating between 20.04 and 20.10. Both has theosfingerset toPop-20.So include the full version in the
osfingergrain.This merge request is the third in the series after merge request #61597 and #61589.