Add tiamat package information for 3005 release notes#61930
Add tiamat package information for 3005 release notes#61930Ch3LL merged 5 commits intosaltstack:masterfrom
Conversation
|
It's not clear from the wording whether distro-native packages are "old deprecated packaging" or whether tiamat is only replacing python-native packages. Dropping support for package formats that no one else considers to be either "old" or "deprecated" seems like a dubious move. I would suggest at least to wrap the tiamat packages in distro-native packages to not unnecessarily increase the user burden, and I really hope tiamat's single binary file is not the only supported format. |
|
@jfindlay Hi Justin, actually dropping the old-style native packaging with a repo where all of the dependencies are also available, as in https://repo.saltproject.io/py3/redhat/7/x86_64/archive/3004.1 The new Tiamat packages will be available as an rpm in RedHat's case, similar for Debian / Ubuntu deb, but inside will be the self-contained Tiamat package with all of its dependencies internal to it, including it's own version of Python, so for example, upcoming Phosphorous Release for RedHat 7 will be making use of Python 3.9 which allows us to make use of recent improvements, rather than having to use the End Of Life'd Python 3.6 on RHEL 7 or 8 for that matter. Already have people wanting us to build with Python 3.8 or 3.9 on Centos 8 where they are available, Tiamat is the solution that allows us to move forward. FYI been using Tiamat packaging on Arista for a couple of years now, which is basically Centos 7 underneath the covers with Arista additions etc. With the Phosphorous release, you will now be able to pip install into the Tiamat solution too, not something you want to do on routers, so wasn't an issue there. Using onedir mode of PyInstaller underneath the covers, to ensure that daemonization has no issues. |
There was a problem hiding this comment.
Looking really good, but I do have some grammar and phrasing suggestions.
I made a few of the grammar suggestions using the commit suggestion feature. I don't know if that's annoying or if it's helpful, so let me know what your preference is.
We need to make a style decision about whether "Tiamat" is capitalized or not. I'm not sure which is best and I'm open to suggestions. We just need to make a decision and stick with it.
In light of these changes, we need to make updates to our official support policy on the new install guide. I've opened up an issue to track this task: https://gitlab.com/saltstack/open/docs/salt-install-guide/-/issues/27
barbaricyawps
left a comment
There was a problem hiding this comment.
Nice work!
I have a few more comments on things I didn't catch on the first pass. All of my comments in this review are minor and non-blocking, so I'm approving this PR. You can consider the minor changes I suggest, but you don't need my re-review on it.
ITJamie
left a comment
There was a problem hiding this comment.
Pip.installed default python question
barbaricyawps
left a comment
There was a problem hiding this comment.
I have some questions and suggestions for you, @Ch3LL . Let me know what you think!
doc/topics/releases/3005.rst
Outdated
There was a problem hiding this comment.
Suggestion (rephrase for clarity, blocking): Instead of "This will be" let's say "The Phosphorus 3005 is the last release..."
doc/topics/releases/3005.rst
Outdated
There was a problem hiding this comment.
Chore (future action, not blocking): I don't yet have the official URL set up for the Salt Install Guide, but when we do, we should link to the policy where we state this. I've been waiting for Derek to return for putting that request in to Kirill in case Kirill wanted to ask Derek questions about the URL setup.
doc/topics/releases/3005.rst
Outdated
There was a problem hiding this comment.
Chore (future action needed, not sure if this is blocking): The instructions won't be on repo, they'll be on the new Salt install guide. See my previous comment about the URL. Do you need me to expedite the URL request because it will block these release notes?
doc/topics/releases/3005.rst
Outdated
There was a problem hiding this comment.
Suggestion: Rather than duplicating install instructions in both the release notes and the install guide, we should probably just link to the install guide. Do you need me to get those URLs set up now?
doc/topics/releases/3006.rst
Outdated
There was a problem hiding this comment.
Suggestion (blocking): The install directions are going to be deprecated from repo. We should link to the install guide instead.
doc/topics/releases/3006.rst
Outdated
There was a problem hiding this comment.
Chore: We'll want to add the link to the policy here as well.
doc/topics/releases/3006.rst
Outdated
There was a problem hiding this comment.
Question: I have the same question as above re: linking to latest, minor, major for Tiamat.
doc/topics/releases/3006.rst
Outdated
There was a problem hiding this comment.
Suggestion: Same suggestion as above. The repo install instructions will be deprecated over time, so we'll want to link to the new guide.
doc/topics/releases/3006.rst
Outdated
There was a problem hiding this comment.
Suggestion: Same suggestion as above where I don't think we should duplicate install content and should instead link out to the install guide.
dmurphy18
left a comment
There was a problem hiding this comment.
Check Cento 8 Stream and Centos 9 comments about Tiamat support
doc/topics/releases/3006.rst
Outdated
There was a problem hiding this comment.
Debian 9 is EOL June 30th 2022, 21 days time, don't think we need to mention it for 3006
doc/topics/releases/3006.rst
Outdated
There was a problem hiding this comment.
Can probably pull Debian 9 for 3006 since EOL 30th June 2022
doc/topics/releases/3005.rst
Outdated
There was a problem hiding this comment.
Thought we were dropping Debian 9 for 3005 since it EOLs 30th June 2022
dmurphy18
left a comment
There was a problem hiding this comment.
Mostly Debian 9 isn't going to make 3005, never mind 3006 since EOL 30th June 2022 and have agree to not support it after end of the month
What does this PR do?
Add information to 3005 release notes about the new tiamat packages
What issues does this PR fix or reference?
Fixes: #61801