Put back deprecation warnings#63315
Merged
Merged
Conversation
s0undt3ch
previously approved these changes
Dec 13, 2022
Ch3LL
previously approved these changes
Dec 13, 2022
Contributor
|
@waynew Thanks for tracking that down! Does it make sense to add a unit test to check that deprecation warnings actually work? IMO this feature is important enough to warrant a dedicated test case. The regression was left undetected for a couple of years! |
waynew
force-pushed
the
fix/warnings/restore-deprecation
branch
from
f24a478 to
1bc9527
Compare
Checked the https://docs.python.org/3/library/warnings.html#warnings.filterwarnings docs but there wasn't any obvious reason why our warnings disappear. This restores the DeprecationWarnings showing up on the command line.
Rather than just rely on the test suite, we also add a deprecation warning to the test module, which will enable a simple method for ensuring that DeprecationWarnings are correctly emitted.
s0undt3ch
force-pushed
the
fix/warnings/restore-deprecation
branch
from
1bc9527 to
9c896fe
Compare
Ch3LL
previously approved these changes
Dec 21, 2022
s0undt3ch
suggested changes
Dec 25, 2022
Contributor
s0undt3ch
left a comment
s0undt3ch
left a comment
There was a problem hiding this comment.
Test failures look valid.
waynew
force-pushed
the
fix/warnings/restore-deprecation
branch
6 times, most recently
from
7ec752c to
ee0accb
Compare
Due to some of the versions of dependencies we're using, these tests may emit some specific errors.
waynew
force-pushed
the
fix/warnings/restore-deprecation
branch
from
ee0accb to
0d48439
Compare
Contributor
Author
|
Last failures look like flaky bits |
Contributor
Author
|
@s0undt3ch test failures look to be sorted, finally 🙃 |
s0undt3ch
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #62185 - now we emit DeprecationWarnings again.
Can test against the MCVE in #59917
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
[x] Docs[ ] Tests written/updatedCommits signed with GPG?
Yes