Skip to content

[DOC][master] #63469 Issue - Replaced the key rejection paragraph with suggested fix & Added a links..#63584

Open
v-aryan wants to merge 2 commits intosaltstack:masterfrom
v-aryan:submain
Open

[DOC][master] #63469 Issue - Replaced the key rejection paragraph with suggested fix & Added a links..#63584
v-aryan wants to merge 2 commits intosaltstack:masterfrom
v-aryan:submain

Conversation

@v-aryan
Copy link

@v-aryan v-aryan commented Jan 30, 2023

What does this PR do?

This PR fixes the first suggested issue which is mentioned in the guides for replacing the content with another and adding a link for [removal/rejection sections]

What issues does this PR fix or reference?

Fixes:
The Salt Master generates a new AES key to encrypt its publications at certain events such as a Master restart or the removal of a Minion key. If you are encountering this problem of too many minions re-authing against the Master, you will need to recalibrate your setup to reduce the rate of events like a Master restart or Minion key removal (salt-key -d).

To

The Salt Master generates a new AES key to encrypt its publications at certain events such as a Master restart or the removal/rejection of a Minion key. If you are encountering this problem of too many minions re-authing against the Master, you will need to recalibrate your setup to reduce the rate of events like a Master restart, Minion key removal (salt-key -d) or Minion key rejection (salt-key -r).

And

A rotating AES key is used to encrypt jobs that are sent to the Salt minion by the Salt master, and to encrypt connections to the Salt master fileserver. A new key is generated and used each time the Salt master restarts and each time a Salt minion key is deleted using the salt-key command.

To

A rotating AES key is used to encrypt jobs that are sent to the Salt minion by the Salt master, and to encrypt connections to the Salt master fileserver. A new key is generated and used each time the Salt master restarts and each time a Salt minion key is deleted/rejected using the salt-key command.

Merge requirements satisfied?

First suggested fix was fixed and the second suggested fix cannot be find which is in "ROTATING SECURITY KEYS" later on it was mentioned that it can be founded on next repository ("https://github.com/saltstack/salt-get-started/blob/7d87b3323913e9b5191fee739d52894ac6ed3811/system/communication.md").

@v-aryan v-aryan requested a review from a team as a code owner January 30, 2023 16:16
@v-aryan v-aryan requested review from Ch3LL and removed request for a team January 30, 2023 16:16
@welcome
Copy link

welcome bot commented Jan 30, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@v-aryan
Copy link
Author

v-aryan commented Jan 30, 2023

Please do tell about the changes which are wrong and need to be solved !

@dwoz dwoz added this to the Argon v3008.0 milestone Dec 18, 2023
@dwoz dwoz requested a review from a team as a code owner March 16, 2025 22:09
twangboy
twangboy previously approved these changes Mar 28, 2025
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling mistakes, and should the updated messages wrap at 72 column, or let them free flow and force the user to scroll to end of line, believe they need to wrap similar to the messages being replaced.

@dmurphy18 dmurphy18 changed the title #63469 Issue - Replaced the key rejection paragraph with suggested fix & Added a links.. [DOC] #63469 Issue - Replaced the key rejection paragraph with suggested fix & Added a links.. Mar 28, 2025
@dmurphy18 dmurphy18 added the documentation Relates to Salt documentation label Mar 28, 2025
@dmurphy18 dmurphy18 changed the title [DOC] #63469 Issue - Replaced the key rejection paragraph with suggested fix & Added a links.. [DOC][master] #63469 Issue - Replaced the key rejection paragraph with suggested fix & Added a links.. Mar 28, 2025
@twangboy
Copy link
Contributor

Please address the changes requested above

@twangboy twangboy added the pending-changes The pull request needs additional changes before it can be merged label May 20, 2025
@twangboy twangboy added the test:full Run the full test suite label Jun 10, 2025
@twangboy
Copy link
Contributor

Fixed the typos

@twangboy
Copy link
Contributor

twangboy commented Aug 7, 2025

Looks like there's a problem generating the man pages

@twangboy
Copy link
Contributor

Also, please rebase and resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Relates to Salt documentation pending-changes The pull request needs additional changes before it can be merged test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants