Skip to content

Conversation

@Rudd-O
Copy link

@Rudd-O Rudd-O commented Feb 7, 2024

This only attempts to accelerate repeated contacts with the SSH minion. The amount of data formerly cached is not contemplated in this patch, due to the complexity of ensuring that all that data is invalidated.

What does this PR do?

Accelerates repeated contacts with SSH minions by roughly 1 second, or more if latency is high.

Halves the total amount of SSH connections established with SSH minions.

In particular, orchestration runs become faster.

Most of the change is indentation whitespace.

What issues does this PR fix or reference?

None.

Previous Behavior

Every SSH minion run was prefaced with a test.opts_pkg call, slowing down minion runs.

New Behavior

SSH minion runs recently contacted to obtain the test.opts_pkg
data are not contacted for that data anymore. Instead, this data is read from a local minion
cache file, which is properly locked to protect data integrity.

This is by default turned off.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes.

@welcome
Copy link

welcome bot commented Feb 7, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Partially restore SSH minion cache. [master] Partially restore SSH minion cache. Feb 7, 2024
@Rudd-O Rudd-O force-pushed the master branch 10 times, most recently from c64c23e to 685aacf Compare February 7, 2024 05:22
This only attempts to accelerate repeated contacts with the SSH minion.
The amount of data formerly cached is not contemplated in this patch,
due to the complexity of ensuring that all that data is invalidated.
@Rudd-O Rudd-O marked this pull request as ready for review February 7, 2024 05:30
@Rudd-O Rudd-O requested a review from a team as a code owner February 7, 2024 05:30
@Rudd-O Rudd-O requested review from whytewolf and removed request for a team February 7, 2024 05:30
@Rudd-O Rudd-O changed the title [master] Partially restore SSH minion cache. [master] Add a minimal SSH test.pkg_opts minion cache. Feb 7, 2024
@dwoz dwoz requested a review from a team as a code owner March 16, 2025 22:09
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need a test

@twangboy twangboy added the test:full Run the full test suite label Jul 1, 2025
@twangboy twangboy added this to the Argon v3008.0 milestone Jul 1, 2025
@twangboy twangboy added the needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants