[master] Add a minimal SSH test.pkg_opts minion cache. #66016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only attempts to accelerate repeated contacts with the SSH minion. The amount of data formerly cached is not contemplated in this patch, due to the complexity of ensuring that all that data is invalidated.
What does this PR do?
Accelerates repeated contacts with SSH minions by roughly 1 second, or more if latency is high.
Halves the total amount of SSH connections established with SSH minions.
In particular, orchestration runs become faster.
Most of the change is indentation whitespace.
What issues does this PR fix or reference?
None.
Previous Behavior
Every SSH minion run was prefaced with a
test.opts_pkgcall, slowing down minion runs.New Behavior
SSH minion runs recently contacted to obtain the
test.opts_pkgdata are not contacted for that data anymore. Instead, this data is read from a local minion
cache file, which is properly locked to protect data integrity.
This is by default turned off.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes.