Skip to content

Conversation

@the-nando
Copy link

@the-nando the-nando commented Feb 13, 2024

What does this PR do?

This PR implements version handling for packages installed via the apk module.

What issues does this PR fix or reference?

Fixes: #66053

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@the-nando the-nando requested a review from a team as a code owner February 13, 2024 10:54
@the-nando the-nando requested review from dwoz and removed request for a team February 13, 2024 10:54
@welcome
Copy link

welcome bot commented Feb 13, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Handle pkg version for apk [master] Handle pkg version for apk Feb 13, 2024
@the-nando the-nando changed the base branch from master to 3006.x February 13, 2024 10:56
@the-nando the-nando requested a review from s0undt3ch as a code owner February 13, 2024 10:56
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Handle pkg version for apk [3006.x] Handle pkg version for apk Feb 13, 2024
@the-nando the-nando changed the base branch from 3006.x to master February 13, 2024 10:56
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [3006.x] Handle pkg version for apk [master] Handle pkg version for apk Feb 13, 2024
@s0undt3ch s0undt3ch added the needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Feb 13, 2024
Copy link
Contributor

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing tests.

@the-nando
Copy link
Author

@s0undt3ch as far as can I see there are no tests at all for apk pkg and setting them up from scratch isn't a simple task I'm afraid. I can leave this open as is for someone to add tests or close it, whichever you prefer.

@s0undt3ch
Copy link
Contributor

@s0undt3ch as far as can I see there are no tests at all for apk pkg and setting them up from scratch isn't a simple task I'm afraid. I can leave this open as is for someone to add tests or close it, whichever you prefer.

I'm not asking for full test coverage of the apk module, of course, and yes, there should already exist some test coverage for it, but sadly, there's not.

I'm basically asking for a regression test for the change you did, a unit test which validates installing a package with and without a version.

If you don't feel up for it, we'll leave it open for a while in case someone wants to pick it up.

There really is no bandwidth from the core team right now to add these.

@dwoz dwoz requested a review from a team as a code owner March 16, 2025 22:09
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog and a test

@twangboy
Copy link
Contributor

Also needs to be rebased and conflicts resolved

@twangboy twangboy added this to the Argon v3008.0 milestone Jul 1, 2025
@twangboy twangboy added the test:full Run the full test suite label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Handle pkg version for apk

3 participants