-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[master] Handle pkg version for apk #66054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pkg : apk handle version
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
s0undt3ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing tests.
|
@s0undt3ch as far as can I see there are no tests at all for apk pkg and setting them up from scratch isn't a simple task I'm afraid. I can leave this open as is for someone to add tests or close it, whichever you prefer. |
I'm not asking for full test coverage of the apk module, of course, and yes, there should already exist some test coverage for it, but sadly, there's not. I'm basically asking for a regression test for the change you did, a unit test which validates installing a package with and without a version. If you don't feel up for it, we'll leave it open for a while in case someone wants to pick it up. There really is no bandwidth from the core team right now to add these. |
twangboy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog and a test
|
Also needs to be rebased and conflicts resolved |
What does this PR do?
This PR implements version handling for packages installed via the apk module.
What issues does this PR fix or reference?
Fixes: #66053
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes