[3007.x] Add MAINTAIN (m) privilege to postgres module lookup tables

[jdelic]

What does this PR do?

Adds MAINTAIN (m) to the supported privileges in salt.modules.postgres.

What issues does this PR fix or reference?

Fixes #66962

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

[twangboy]

Would you mind writing a test for this?

[elpavel]

Is there a way to test this @twangboy ? The current test suite doesn't run tests against a Postgres database (if I remember well).

I did implement the same change as in this patch in our salt, to allow privileges management on our Postgres 17 databases. Thanks @jdelic it works OK.

[twangboy]

Looks like there's a test failure.

[jdelic]

@twangboy thank you for the approval. I don't think the CI has run my modified tests yet... Any idea how to get them to run? It looks to me like a failure on the test infrastructure 🤷‍♂️

[twangboy]

With the recent changes to our internal infrastructure mandated echelons above us with minimal notice, most of our pipeline is broken. Once it is fixed you can rebase and the tests should run.

[jdelic]

@twangboy yeah, I realized that the pipelines don't yet point to the Broadcom endpoints. 😁

I'll wait for the 3007.x branch to be fixed and proceed accordingly. Thank you 🙏

[evkuzin]

What are the blockers here? I’m very much in need of this change 🥺

[jdelic]

@evkuzin
like most other new PRs this one is blocked on the URL changes from #67024 and possibly #67022 and #67101 landing. Once these are merged the build infrastructure should work again, at which point I can rerun the required tests, which will allow this one to be merged by the maintainers.

I don't know why the breaking change had to be done in this way instead of the many ways it could have been done that wouldn't have broken users and build systems and support processes, but your guess is as good as mine.

[jdelic]

@twangboy I reran the tests now that #67024 has landed and this is ready to merge 🎉