Fix local_cache in multi_returner #67880
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes incorrect storage of
_return-type job results in local_cache when usingmulti_returnerconfiguration. Now strictly follows the logic insalt.utils.job.store_jobby only executing multi-returner storage whenload['cmd']is not equal to'_return'.What issues does this PR fix or reference?
None
Previous Behavior
With multi-returner configuration:
All types of return data (including
cmd: _returnjob results) were stored inlocal_cache, violating the expected behavior defined in store_job logic:salt/salt/utils/job.py
Lines 127 to 130 in f906ca5
New Behavior
Now only save_load when
returner_ == "local_cache" and load['cmd'] != '_return'Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No