add bugfix/68506-minion-connect-retry#68743
Draft
harshang03 wants to merge 1 commit intosaltstack:masterfrom
Draft
add bugfix/68506-minion-connect-retry#68743harshang03 wants to merge 1 commit intosaltstack:masterfrom
harshang03 wants to merge 1 commit intosaltstack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves minion/master connection resiliency by treating transient transport failures as retryable instead of fatal.
Adds shared retry classification helpers in salt/utils/zeromq.py (including handling for transient Tornado callback race errors like TypeError: 'NoneType' object is not iterable).
Exposes transport-level retry/error formatting helpers in salt/transport/init.py.
Updates minion/syndic connection flows in salt/minion.py to:
retry transient connection errors with backoff,
normalize retryable transport failures into SaltClientError,
keep non-retryable exceptions as hard failures.
Adds/updates unit tests for retry classification and minion retry behavior.
What issues does this PR fix or reference?
Fixes #68506
Previous Behavior
A transient transport exception during connect (including Tornado callback race-style failures) could prematurely abort minion/syndic connect flow, resulting in “minion does not connect to master” behavior.
New Behavior
Transient transport/connect exceptions are detected and retried consistently. Minion and syndic connect loops now continue retrying with bounded backoff for retryable failures, while still surfacing non-retryable failures.
Merge requirements satisfied?
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No