[WIP] Fix compound commands on Windows#68825
Open
twangboy wants to merge 2 commits intosaltstack:3006.xfrom
Open
[WIP] Fix compound commands on Windows#68825twangboy wants to merge 2 commits intosaltstack:3006.xfrom
twangboy wants to merge 2 commits intosaltstack:3006.xfrom
Conversation
bdrx312
reviewed
Mar 31, 2026
| ("echo \"foo 'bar'\"", "\"foo 'bar'\""), | ||
| ('echo|set /p="foo" & echo|set /p="bar"', "foobar"), | ||
| ('''echo "&<>[]|{}^=;!'+,`~ "''', '''"&<>[]|{}^=;!'+,`~ "'''), | ||
| # ('''echo "&<>[]|{}^=;!'+,`~ "''', '''"&<>[]|{}^=;!'+,`~ "'''), |
Contributor
There was a problem hiding this comment.
Reminder to add back a test testing these characters
bdrx312
reviewed
Apr 1, 2026
Comment on lines
1347
to
1348
| cmd must be double-quoted to ensure proper handling of space characters. The first opening | ||
| quote and the closing quote are stripped automatically by the Win32 API. |
Contributor
There was a problem hiding this comment.
Does this comment still apply with the change below? Is this going to break cases that were already quoting the command?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No