fixed bad copy paste errors according to the issue https://github.com…#68988
Open
arinochk wants to merge 1 commit into
Open
fixed bad copy paste errors according to the issue https://github.com…#68988arinochk wants to merge 1 commit into
arinochk wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the report and the fix. You will need to add a change log. See https://docs.saltproject.io/en/latest/topics/development/contributing.html. The maintainers now also require adding test cases to the automated pytests; so, I am sure they will request that you add some tests before they approve this. |
Author
|
Hi! Unfortunately, I won't be able to write the tests at the moment, as I don't know how you write them. I'd appreciate it if someone could help with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes two separate issues:
What issues does this PR fix or reference?
Fixes #68967
Previous Behavior
New Behavior
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No