pkg.list_patches in yumpkg.py parses tdnf output on Photon OS#69230
Merged
Conversation
498ada7 to
0a9ebc7
Compare
dwoz
previously approved these changes
May 26, 2026
80cf988 to
7a27f48
Compare
7a27f48 to
4442970
Compare
4442970 to
e51c2fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
yumpkg.pyto properly handle the output oftdnf updateinfo list allon Photon OS. It accommodates the lack of leading spaces or status characters (likei) intdnfoutput so that patches can be successfully parsed.What issues does this PR fix or reference?
Fixes #69229
Previous Behavior
Running
salt * pkg.list_patcheson a Photon OS minion returned empty or failed to list available patches because the regex parser ignored lines starting flush withpatch:.New Behavior
The
yumpkg.pymodule now correctly identifies and returns available patches on Photon OS, while maintaining full parsing compatibility with RHEL/Rocky/Almadnfandyumoutputs.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes