Remove orphaned genesis utility modules (refs #57990)#69237
Open
ggiesen wants to merge 1 commit into
Open
Conversation
salt.utils.kickstart, salt.utils.preseed and salt.utils.yast were only
used by the genesis execution module, which was moved out to a community
extension in 65970 ("Remove community extensions from Salt codebase").
The util modules were left behind with no remaining consumers, so remove
them along with the now-stale test_kickstart.py.
The genesis.mksls keyboard-parsing bug reported in saltstack#57990 lived in
salt.utils.kickstart.parse_keyboard; the fix is recorded on that issue for
anyone reviving genesis as an extension.
This was referenced May 27, 2026
Contributor
|
@ggiesen Should this be against 3008.x? It's too late for 3008.0 but if this is fixing a bug it can go into 3008.1 |
Contributor
Author
|
@dwoz this one isn't a bug fix - it removes the orphaned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes three orphaned utility modules and a stale test:
salt/utils/kickstart.pysalt/utils/preseed.pysalt/utils/yast.pytests/unit/utils/test_kickstart.pyThese utilities were only ever consumed by the
genesisexecution module, which was moved out of Salt core to a community extension (#65970 / dc526dc, "Remove community extensions from Salt codebase"). The util modules were left behind. A repo-wide search confirms nothing insalt/importssalt.utils.kickstart,salt.utils.preseedorsalt.utils.yastanymore -- the only remaining reference was thetest_kickstart.pyunit test, which is removed here as well.What issues does this PR fix or reference?
Refs #57990, #57991
Both issues are
genesis.mkslskickstart-parsing bugs insalt.utils.kickstart: #57990 (parse_keyboarddeclared the legacykeyboardlayout as a required positional, so modernkeyboard --vckeymap=... --xlayouts=...lines made argparse exit) and #57991 (parse_networkdidn't recognize the--no-activateoption).genesisis gone from core, so standalone fixes are recorded on each issue for anyone reviving genesis as an extension; this PR removes the now-unreachable code rather than patching it.Previous Behavior
salt/utils/{kickstart,preseed,yast}.pyshipped in core with no remaining importers after the genesis module was removed.New Behavior
The orphaned modules and their stale test are gone.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
changelog/57990.removed.mdtests/unit/utils/test_kickstart.py; no new tests apply to a code removalCommits signed with GPG?
No