Sign request loads in _package_load, not in _send_req_*#69246
Open
dwoz wants to merge 1 commit into
Open
Conversation
Akm0d
previously approved these changes
May 29, 2026
Fixes saltstack#68181 The minion was signing before AsyncReqChannel attached nonce/ts/tok, so master verification re-serialized different bytes and every signed return was dropped. Sign inside _package_load after the metadata is attached; remove the now-redundant signing from the five _send_req_* methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68181
The minion was signing before AsyncReqChannel attached nonce/ts/tok, so master verification re-serialized different bytes and every signed return was dropped. Sign inside _package_load after the metadata is attached; remove the now-redundant signing from the five send_req* methods.