Skip to content

Fix logging level of __virtual__() module#69708

Open
foklan wants to merge 7 commits into
saltstack:3006.xfrom
foklan:fix-66927
Open

Fix logging level of __virtual__() module#69708
foklan wants to merge 7 commits into
saltstack:3006.xfrom
foklan:fix-66927

Conversation

@foklan

@foklan foklan commented Jul 5, 2026

Copy link
Copy Markdown

What does this PR do?

What issues does this PR fix or reference?

Fixes

Previous Behavior

Error messages from module __virtual__() were logged at error level.

New Behavior

Error messages from module __virtual__() are logged at debug level.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@foklan foklan requested a review from a team as a code owner July 5, 2026 13:46
@welcome

welcome Bot commented Jul 5, 2026

Copy link
Copy Markdown

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We're glad you've joined our community and look forward to doing awesome things with you!

Comment thread tests/unit/test_loader.py Outdated
)

def test_keyerror_is_debug_not_error(self):
module = """

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use tests.support.helpers.dedent instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants