Migrate remaining resources to typed Id (#156) by saltyskip · Pull Request #175 · saltyskip/rift

saltyskip · 2026-05-29T13:18:09Z

Summary

Stacked on top of #174. Migrates the remaining resources from raw ObjectId to typed Id. Backlog reduced from 44 → 38 entries; the structural pattern is established and the remaining files are mechanical follow-ups.

Resources migrated in this PR

domains — Domain { id: DomainId, tenant_id: TenantId }. Routes use Path<DomainId>. Off the backlog.
apps — App { id: AppId, tenant_id: TenantId }. AppDetail.id: AppId. Route uses Path<AppId>. resolve_tenant_from_host returns Option<TenantId>. Off the backlog.
conversions — Source { id: SourceId, tenant_id: TenantId }, ConversionEvent.id: Option<ConversionEventId>, ConversionMeta { tenant_id, source_id } typed. SourceDetail / CreateSourceResponse / MCP CreateSourceOutput / SourceSummary typed.
webhooks — Webhook { id: WebhookId, tenant_id: TenantId }. WebhookDetail.id / CreateWebhookResponse.id typed. Off the backlog.
app_users — added AppUserIdMarker (appusr_). AppUserDoc typed. Off the backlog.
install_events — added InstallEventIdMarker (iev_). InstallEvent typed. Off the backlog.

New markers

Marker	Prefix	Schema name
`AppUserIdMarker`	`appusr`	`AppUserId`
`InstallEventIdMarker`	`iev`	`InstallEventId`
`LinkInternalIdMarker`	`lnk`	`LinkInternalId`

LinkInternalId is staged for the upcoming services/links/models.rs migration. Distinct from the public link_id vanity slug, which stays as a custom String.

Bridges to un-migrated layers

Wherever a service still on the backlog takes &ObjectId, callers bridge with id.as_object_id() or id.to_object_id(). Once those services migrate, the bridges go away.

Remaining (38 files on the backlog)

The remaining work is the same pattern applied to:

Auth core: services/auth/{tenants,users,secret_keys,sessions,oauth,publishable_keys,usage}/models.rs + matching service.rs
Billing: services/billing/{models,quota,service}.rs + repos/
Links: services/links/models.rs + service.rs (uses LinkInternalIdMarker from this PR)
Analytics: services/analytics/service.rs
Webhook payloads: core/models.rs (ClickEventPayload etc.) + services/webhooks/dispatcher.rs — the customer-facing wire-format change. You approved hard cutover earlier.
Route handlers still on backlog: api/auth/*, api/billing/stripe_webhook.rs, api/conversions/routes.rs, api/lifecycle/routes.rs, api/links/routes.rs, api/webhooks/routes.rs, api/affiliates/routes.rs (credential paths)

Test plan

cargo fmt -- --check
cargo clippy --all-targets -- -D warnings
cargo test --lib — 205 tests pass

🤖 Generated with Claude Code

- domains: `Domain { id: DomainId, tenant_id: TenantId }`. Routes use `Path<DomainId>` flow. `services/domains/models.rs` off the backlog. - apps: `App { id: AppId, tenant_id: TenantId }`. `AppDetail.id: AppId`. Routes use `Path<AppId>`. `resolve_tenant_from_host` returns `Option<TenantId>`. `apps/models.rs` and `api/apps/routes.rs` off the backlog. - conversions: `Source { id: SourceId, tenant_id: TenantId }`, `ConversionEvent.id: Option<ConversionEventId>`, `ConversionMeta { tenant_id: TenantId, source_id: SourceId }`, `SourceDetail.id: SourceId`, `CreateSourceResponse.id: SourceId`. MCP `CreateSourceOutput` / `SourceSummary` typed too. `ConversionDedup` stays on backlog (internal-only docu). Cross-resource bridges: - `links/routes.rs` calls `domain.tenant_id.as_object_id()` when passing to repos still on backlog. - `apps/routes.rs` passes `tenant_id.as_object_id()` to apps repo. - `conversions/service.rs` bridges to ObjectId at the ingest boundary (tenant_id, source_id) since the time-series repo still uses ObjectId. Tests: - `links/service_tests.rs` Domain mock uses typed Id. - `conversions/parsers_tests.rs` source factory uses typed Id. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- webhooks: `Webhook { id: WebhookId, tenant_id: TenantId }`, `WebhookDetail.id: WebhookId`, `CreateWebhookResponse.id: WebhookId`. Service takes `WebhookId` for `create_webhook`. Off the backlog. - app_users: added `AppUserIdMarker` (prefix `appusr`). `AppUserDoc` uses `Option<AppUserId>` / `TenantId`. Off the backlog. - install_events: added `InstallEventIdMarker` (prefix `iev`). `InstallEvent` uses `Option<InstallEventId>` / `TenantId`. Off the backlog. Also added `LinkInternalIdMarker` (prefix `lnk`) for the upcoming links model migration — distinct from the public `link_id` vanity slug. Bridges: - `webhooks/routes.rs`: comparisons use `w.id.to_object_id()`. - `install_events/repo.rs`: bridges `*tenant_id` to `TenantId::from_object_id`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

vercel · 2026-05-29T13:18:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
rift	Ready	Preview, Comment	May 29, 2026 4:24pm

…arkers New markers: - `AuthSessionIdMarker` (`sess_`) — user auth sessions - `OAuthSessionIdMarker` (`osess_`) — OAuth flow state Models migrated to typed Id: - `SessionDoc { id: AuthSessionId, user_id: UserId, tenant_id: TenantId }` - `ResolvedSession`, `SignInOutcome` use typed IDs - `TenantDoc.id: Option<TenantId>` - `UserDoc { id: Option<UserId>, tenant_id: TenantId }` - `UserDetail`, `InviteResult`, `VerifyResult` use typed IDs - `OauthCallbackOutcome { user_id: UserId, tenant_id: TenantId }` Axum extension unification: - `api::auth::models::SessionId` is now `pub use crate::core::public_id::AuthSessionId as SessionId` — same trick as Tenant/User: one type, end-to-end. AuthContext + Principal: - `Principal::User { user_id: UserId, session_id: AuthSessionId }` - `AuthContext::for_session` takes typed args Bridges: - `tenants/service.rs::create_blank` mints `TenantId::new()` internally, returns `ObjectId` to existing callers (one-line bridge until call sites migrate). - `users_service::create_tenant_with_verified_owner` still returns ObjectIds; sessions and OAuth services bridge with `from_object_id` at the call site. - `stripe_webhook.rs::try_resolve_tenant` `.map(|t| id.to_object_id())` bridges. - Test mocks updated to mirror typed IDs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Lib + lib tests pass (205 tests, including arch tests). Integration tests under `tests/` need follow-up updates to common mocks for the typed IDs — they reference patterns that changed in the auth/sessions migration. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- `api/affiliates/routes.rs`: credential route handlers use `Path<AffiliateId>` instead of `Path<String>` + manual `ObjectId::parse_str`. - `api/webhooks/routes.rs`: `delete_webhook` and `patch_webhook` use `Path<WebhookId>`. - `services/links/models.rs`: `CreateLinkRequest.affiliate_id`, `BulkLinkTemplate.affiliate_id`, `LinkDetail.affiliate_id` typed as `Option<AffiliateId>`. Drops the custom `serialize_opt_object_id_as_hex` helper for affiliate_id — `Id::serialize` is format-conditional. - `services/links/service.rs`: bridges request `Option<AffiliateId>` to storage `Option<ObjectId>` via `.map(|a| a.to_object_id())`. The response builder maps the other direction. - Integration test fixtures updated to use the prefixed format (`aff_<hex>`, `wh_<hex>`) via `Id::new().to_string()` / `Id::parse(&s)`. Tests: 205 lib + 179 doc + 147 integration all pass. Backlog now 30 (was 44 at start of #175). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- secret_keys/models.rs: `SecretKeyDoc { id: SecretKeyId, tenant_id: TenantId, created_by: UserId }`. `CreatedKey.id`, `KeyDetail.{id,created_by}` typed. - publishable_keys/models.rs: `SdkKeyDoc { id: PublishableKeyId, tenant_id: TenantId }`. - secret_keys delete + sdk_keys revoke + affiliate credential revoke routes all use `Path<SecretKeyId>` / `Path<PublishableKeyId>` (no more manual parse_str). - mint_scoped (secret_keys::service) constructs via `SecretKeyId::new()`. - Middleware `find_secret_key_doc` helper returns ObjectIds via `to_object_id()` at the boundary. - Test fixtures + mocks updated. 205 lib + 179 doc + 147 integration tests pass. Backlog now 28 (was 30). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…odels - `services/links/models.rs::Link`: `id: LinkInternalId`, `tenant_id: TenantId`, `affiliate_id: Option<AffiliateId>` typed end-to-end. - `services/auth/usage/models.rs::UsageDoc`: typed `Option<UsageRowId>` / `Option<SecretKeyId>` (new `UsageRowIdMarker` with prefix `usage`). - `services/conversions/models.rs::ConversionDedup`: `id: ConversionDedupId`, `tenant_id: TenantId` (new `ConversionDedupIdMarker` with prefix `cdedup`). - `services/auth/publishable_keys/models.rs::SdkKeyDoc` typed too. - `services/billing/models.rs::EventCounterDoc.tenant_id` typed. - Link list cursor parses via `LinkInternalId::parse` then `.to_object_id()`. - `api/lifecycle/routes.rs` builds `IdentifyEventPayload.tenant_id` as `TenantId::from_object_id(*tenant_id).to_string()` so the webhook wire format is the prefixed string. - Many test fixtures + repo internals updated with `from_object_id` bridges. - 205 lib + 179 doc + 147 integration tests all pass. Backlog: 24 (was 28). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…/webhooks routes from backlog

…nantId

…ssions/models

…r typed

…t) to typed IDs

… to zero

* Add Id type + strict ObjectId-confinement architecture rule (#156) The actual problem with #156 wasn't the hex string format — it's that `mongodb::bson::oid::ObjectId` (a type from the mongo crate) was being passed through service-layer models, transport handlers, webhook payloads, and MCP tool inputs. Every layer that mentioned an ID transitively depended on MongoDB. This PR fixes the architectural smell, not the format: - `core::public_id::Id` wraps a 24-char ObjectId hex string. Wire format is `<prefix>_<hex>` (e.g. `aff_665a1b2c3d4e5f6a7b8c9d0e`), added on serialize, validated on deserialize. Marker `P` makes per-resource aliases (`AffiliateId`, `TenantId`, …) distinct types at compile time. - `Id::from_object_id(oid)` / `id.to_object_id()?` form the bridge. Repos own these calls; everyone else just passes the typed value. - No new ID format, no data migration, no backfill, no schema change. The underlying value is still the raw ObjectId hex — just with a prefix at the API boundary. Enforcement is structural, not advisory: - `architecture_tests::object_id_confined_to_storage_layer` walks `src/` and bans the word `ObjectId` everywhere except an allowlist: `**/repo.rs`, `migrations/**`, `core/db.rs`, `core/public_id/mod.rs`, `app.rs`, `main.rs`, `*_tests.rs`. New files inherit the rule. - `OBJECT_ID_BACKLOG` lists existing violator files (45 entries); follow-up commits remove them one at a time. - `object_id_backlog_entries_still_have_violations` is the symmetric test: a file on the backlog must still contain `ObjectId`, or the test fails. The backlog can only shrink. Files added/modified: - `core/public_id/mod.rs` — type, trait, all 10 marker types, impls (Serialize/Deserialize, Display, FromStr, Hash, Ord, utoipa `ToSchema` + `PartialSchema`, schemars `JsonSchema` under `mcp`) - `core/public_id/models.rs` — `ParseIdError`, 10 type aliases - `core/public_id/public_id_tests.rs` — 18 unit tests - `core/mod.rs` — register `pub mod public_id` - `architecture_tests.rs` — new test + backlog + 6 parser tests - `CLAUDE.md` — new "Public identifiers" section Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Id: format-conditional serde so one struct serves both BSON and JSON The whole reason we were planning a Doc/Response split per resource: BSON ObjectId can't deserialize into a string-backed type, and our `Id` is string-backed. Without this commit, every `models.rs` would need a private storage struct in repo.rs plus a conversion helper. With this commit, `Id` branches on `Serializer::is_human_readable()`: - JSON / OpenAPI / MCP wire format: prefixed string `aff_<hex>` - BSON (raw, non-human-readable — the path the mongodb driver uses): native ObjectId binary So a struct `Affiliate { id: AffiliateId, tenant_id: TenantId, name: String }` serializes correctly to both MongoDB (BSON ObjectIds for `_id` and `tenant_id`) and to HTTP responses (prefixed strings). No Doc/Response split, no conversion helpers, no per-resource refactor beyond changing field types. Per-resource migration now collapses to mechanical search/replace: - `id: ObjectId` → `id: AffiliateId` (per type) - `&ObjectId` parameters → `&AffiliateId` - `Path<String>` + manual parse → `Path<AffiliateId>` - `ObjectId::new()` → `AffiliateId::new()` Note on `bson::to_bson` vs the driver path: bson 2.x's `to_bson` defaults to human_readable=true (returns a string for our type). The actual mongodb driver uses `to_raw_document_buf` internally, which is non-human-readable and produces ObjectId binary. The tests exercise the raw path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Migrate affiliates to typed Id + supporting Id ergonomics - Add `Id::new()` (generates a fresh ObjectId hex) and `Default` impl. - Add `From<Id> for Bson` so `doc! { "_id": id }` produces a native BSON ObjectId without round-tripping through serde. Affiliates resource migrated end-to-end: - `services/affiliates/models.rs` — `Affiliate { id: AffiliateId, tenant_id: TenantId, .. }`, `AffiliateDetail.id` typed, `MintedCredential.affiliate_id` typed. File no longer imports `mongodb::bson::oid::ObjectId`. - `services/affiliates/repo.rs` — trait signatures take `&TenantId` / `&AffiliateId` (the `From<Id> for Bson` impl lets the existing `doc!` queries work unchanged). - `services/affiliates/service.rs` — CRUD methods take `AffiliateId`; bridges to `ctx.tenant_id` (still `ObjectId` in AuthContext, 136 call sites — separate migration) via `.into()` at the boundary. Credential methods (`mint_credential`, `list_credentials`, `revoke_credential`) still take `ObjectId` until secret_keys migrates. - `api/affiliates/routes.rs` — CRUD route handlers use `Path<AffiliateId>` directly; no more manual `ObjectId::parse_str`. `to_detail` just clones the typed id. - `services/links/service.rs` and `services/billing/repos/resource_counts_adapter.rs` bridge their `&ObjectId` to the new typed signature with `.into()`. - `tests/common/mocks/affiliates.rs` updated to match the new trait. Removed `src/services/affiliates/models.rs` from `OBJECT_ID_BACKLOG`. `service.rs` and `routes.rs` stay on the backlog (credential paths still use ObjectId pending the secret_keys migration). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Unify TenantId/UserId/AffiliateId through axum extensions → AuthContext → services The marker-type safety story now actually delivers: there is one typed `TenantId`, one typed `UserId`, one typed `AffiliateId` across the entire codebase. They flow unchanged from the auth middleware through services down to repo boundaries. Restructured `Id`: - Stores `ObjectId` directly instead of a `String` hex (fixes the agent's perf + reachable-`expect` concerns). `to_object_id()` is now infallible. - `Copy` derived — eliminates `clone()` noise at every plumbing call site. - Removed the blanket `impl<P: IdPrefix> From<ObjectId> for Id` — conversions must name the target type via `TenantId::from_object_id(oid)`, so cross-resource mixups are caught at review. - Dropped `Default` — defaults must be cheap/deterministic; `new()` mints a fresh ObjectId (clock + counter) and is explicit. - `SecretKeyIdMarker::PREFIX` changed from `"sk"` to `"skid"` to avoid collision with Stripe's `sk_live_` / `sk_test_` muscle memory. Unification: - `api/auth/models.rs` re-exports `core::public_id::{TenantId, UserId}` — the old `TenantId(pub ObjectId)` / `UserId(pub ObjectId)` newtypes are gone. `Extension<TenantId>` is the typed value end-to-end. - `auth/middleware.rs` constructs `TenantId::from_object_id(oid)` / `UserId::from_object_id(oid)` once at the auth boundary. - `AuthContext.tenant_id: TenantId`, `Principal::User { user_id: UserId, .. }`, `ResourceScope::Affiliate { affiliate_id: AffiliateId }`. - ~28 axum extension call sites flow the typed value through (no `.0` access). - Affiliate credentials (`mint_credential` / `list_credentials` / `revoke_credential`) take `AffiliateId` — affiliates is now fully migrated. Bridges to un-migrated layers: - `ctx.tenant_id.as_object_id()` for repos that still take `&ObjectId` (most repos; per-resource migration is follow-up work). - `ctx.tenant_id.to_object_id()` for owned ObjectId needs (BSON metadata, Sentry tags via `.to_string()`). - `affiliate_id.to_object_id()` when calling secret_keys repo (still ObjectId). Architecture test: - Tightened `*_tests.rs` allowlist: a `*_tests.rs` file now only counts as a sibling-test if there's another non-test `.rs` file in the same directory. Closes the "name any file `_tests.rs` to bypass" escape. - `architecture_tests.rs` itself added to the explicit allowlist (mentions the word in parser tests and error messages). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Migrate remaining resources to typed Id (#156) (#175) * Migrate domains, apps, conversions to typed Id - domains: `Domain { id: DomainId, tenant_id: TenantId }`. Routes use `Path<DomainId>` flow. `services/domains/models.rs` off the backlog. - apps: `App { id: AppId, tenant_id: TenantId }`. `AppDetail.id: AppId`. Routes use `Path<AppId>`. `resolve_tenant_from_host` returns `Option<TenantId>`. `apps/models.rs` and `api/apps/routes.rs` off the backlog. - conversions: `Source { id: SourceId, tenant_id: TenantId }`, `ConversionEvent.id: Option<ConversionEventId>`, `ConversionMeta { tenant_id: TenantId, source_id: SourceId }`, `SourceDetail.id: SourceId`, `CreateSourceResponse.id: SourceId`. MCP `CreateSourceOutput` / `SourceSummary` typed too. `ConversionDedup` stays on backlog (internal-only docu). Cross-resource bridges: - `links/routes.rs` calls `domain.tenant_id.as_object_id()` when passing to repos still on backlog. - `apps/routes.rs` passes `tenant_id.as_object_id()` to apps repo. - `conversions/service.rs` bridges to ObjectId at the ingest boundary (tenant_id, source_id) since the time-series repo still uses ObjectId. Tests: - `links/service_tests.rs` Domain mock uses typed Id. - `conversions/parsers_tests.rs` source factory uses typed Id. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Migrate webhooks, app_users, install_events to typed Id - webhooks: `Webhook { id: WebhookId, tenant_id: TenantId }`, `WebhookDetail.id: WebhookId`, `CreateWebhookResponse.id: WebhookId`. Service takes `WebhookId` for `create_webhook`. Off the backlog. - app_users: added `AppUserIdMarker` (prefix `appusr`). `AppUserDoc` uses `Option<AppUserId>` / `TenantId`. Off the backlog. - install_events: added `InstallEventIdMarker` (prefix `iev`). `InstallEvent` uses `Option<InstallEventId>` / `TenantId`. Off the backlog. Also added `LinkInternalIdMarker` (prefix `lnk`) for the upcoming links model migration — distinct from the public `link_id` vanity slug. Bridges: - `webhooks/routes.rs`: comparisons use `w.id.to_object_id()`. - `install_events/repo.rs`: bridges `*tenant_id` to `TenantId::from_object_id`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Migrate auth/{sessions,tenants,users,oauth}/models.rs + add session markers New markers: - `AuthSessionIdMarker` (`sess_`) — user auth sessions - `OAuthSessionIdMarker` (`osess_`) — OAuth flow state Models migrated to typed Id: - `SessionDoc { id: AuthSessionId, user_id: UserId, tenant_id: TenantId }` - `ResolvedSession`, `SignInOutcome` use typed IDs - `TenantDoc.id: Option<TenantId>` - `UserDoc { id: Option<UserId>, tenant_id: TenantId }` - `UserDetail`, `InviteResult`, `VerifyResult` use typed IDs - `OauthCallbackOutcome { user_id: UserId, tenant_id: TenantId }` Axum extension unification: - `api::auth::models::SessionId` is now `pub use crate::core::public_id::AuthSessionId as SessionId` — same trick as Tenant/User: one type, end-to-end. AuthContext + Principal: - `Principal::User { user_id: UserId, session_id: AuthSessionId }` - `AuthContext::for_session` takes typed args Bridges: - `tenants/service.rs::create_blank` mints `TenantId::new()` internally, returns `ObjectId` to existing callers (one-line bridge until call sites migrate). - `users_service::create_tenant_with_verified_owner` still returns ObjectIds; sessions and OAuth services bridge with `from_object_id` at the call site. - `stripe_webhook.rs::try_resolve_tenant` `.map(|t| id.to_object_id())` bridges. - Test mocks updated to mirror typed IDs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Cleanup unused imports + remove sessions/oauth services from backlog Lib + lib tests pass (205 tests, including arch tests). Integration tests under `tests/` need follow-up updates to common mocks for the typed IDs — they reference patterns that changed in the auth/sessions migration. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Migrate affiliate credential routes + link CreateRequest affiliate_id - `api/affiliates/routes.rs`: credential route handlers use `Path<AffiliateId>` instead of `Path<String>` + manual `ObjectId::parse_str`. - `api/webhooks/routes.rs`: `delete_webhook` and `patch_webhook` use `Path<WebhookId>`. - `services/links/models.rs`: `CreateLinkRequest.affiliate_id`, `BulkLinkTemplate.affiliate_id`, `LinkDetail.affiliate_id` typed as `Option<AffiliateId>`. Drops the custom `serialize_opt_object_id_as_hex` helper for affiliate_id — `Id::serialize` is format-conditional. - `services/links/service.rs`: bridges request `Option<AffiliateId>` to storage `Option<ObjectId>` via `.map(|a| a.to_object_id())`. The response builder maps the other direction. - Integration test fixtures updated to use the prefixed format (`aff_<hex>`, `wh_<hex>`) via `Id::new().to_string()` / `Id::parse(&s)`. Tests: 205 lib + 179 doc + 147 integration all pass. Backlog now 30 (was 44 at start of #175). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Migrate secret_keys + publishable_keys models + their delete routes - secret_keys/models.rs: `SecretKeyDoc { id: SecretKeyId, tenant_id: TenantId, created_by: UserId }`. `CreatedKey.id`, `KeyDetail.{id,created_by}` typed. - publishable_keys/models.rs: `SdkKeyDoc { id: PublishableKeyId, tenant_id: TenantId }`. - secret_keys delete + sdk_keys revoke + affiliate credential revoke routes all use `Path<SecretKeyId>` / `Path<PublishableKeyId>` (no more manual parse_str). - mint_scoped (secret_keys::service) constructs via `SecretKeyId::new()`. - Middleware `find_secret_key_doc` helper returns ObjectIds via `to_object_id()` at the boundary. - Test fixtures + mocks updated. 205 lib + 179 doc + 147 integration tests pass. Backlog now 28 (was 30). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Migrate links.Link, conversions.ConversionDedup, billing/auth/usage models - `services/links/models.rs::Link`: `id: LinkInternalId`, `tenant_id: TenantId`, `affiliate_id: Option<AffiliateId>` typed end-to-end. - `services/auth/usage/models.rs::UsageDoc`: typed `Option<UsageRowId>` / `Option<SecretKeyId>` (new `UsageRowIdMarker` with prefix `usage`). - `services/conversions/models.rs::ConversionDedup`: `id: ConversionDedupId`, `tenant_id: TenantId` (new `ConversionDedupIdMarker` with prefix `cdedup`). - `services/auth/publishable_keys/models.rs::SdkKeyDoc` typed too. - `services/billing/models.rs::EventCounterDoc.tenant_id` typed. - Link list cursor parses via `LinkInternalId::parse` then `.to_object_id()`. - `api/lifecycle/routes.rs` builds `IdentifyEventPayload.tenant_id` as `TenantId::from_object_id(*tenant_id).to_string()` so the webhook wire format is the prefixed string. - Many test fixtures + repo internals updated with `from_object_id` bridges. - 205 lib + 179 doc + 147 integration tests all pass. Backlog: 24 (was 28). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Drop analytics + publishable_keys routes + auth/secret_keys/lifecycle/webhooks routes from backlog * Migrate KeyScope::Affiliate.affiliate_id to AffiliateId * Migrate AuthKeyId to wrap SecretKeyId + cached webhook lookup uses TenantId * Migrate Principal::SecretKey.key_id + tenants::create_blank to typed * Migrate links/routes lookup_tenant_domain + auth/users/routes + permissions/models * Migrate sessions/service.revoke + conversions/routes path types * Migrate affiliates credential service methods to typed Ids * Migrate auth/users service: delete + create_tenant_with_verified_owner typed * Middleware validate_api_key returns typed (TenantId, SecretKeyId) * Migrate stripe_webhook helpers to TenantId * Migrate secret_keys service to typed TenantId/UserId/SecretKeyId * Migrate QuotaChecker trait to typed TenantId * Migrate conversions service to typed TenantId/SourceId * Migrate TierResolver trait + BillingService to typed TenantId * Migrate links models (ClickMeta, AttributionEventMeta, CreateLinkInput) to typed IDs * Migrate links service to typed TenantId/AffiliateId — backlog drained to zero * Docs: update prefixed-ID examples in OpenAPI + CLAUDE.md/AGENTS.md --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

saltyskip and others added 2 commits May 29, 2026 08:13

vercel Bot deployed to Preview May 29, 2026 13:18 View deployment

vercel Bot deployed to Preview May 29, 2026 13:38 View deployment

vercel Bot deployed to Preview May 29, 2026 13:41 View deployment

vercel Bot deployed to Preview May 29, 2026 14:00 View deployment

vercel Bot deployed to Preview May 29, 2026 14:10 View deployment

vercel Bot deployed to Preview May 29, 2026 14:34 View deployment

Drop analytics + publishable_keys routes + auth/secret_keys/lifecycle…

4b4d7f6

…/webhooks routes from backlog

vercel Bot deployed to Preview May 29, 2026 14:40 View deployment

Migrate KeyScope::Affiliate.affiliate_id to AffiliateId

1debb70

vercel Bot deployed to Preview May 29, 2026 14:45 View deployment

Migrate AuthKeyId to wrap SecretKeyId + cached webhook lookup uses Te…

a12ae83

…nantId

vercel Bot deployed to Preview May 29, 2026 14:50 View deployment

Migrate Principal::SecretKey.key_id + tenants::create_blank to typed

95fcf3d

vercel Bot deployed to Preview May 29, 2026 14:57 View deployment

Migrate links/routes lookup_tenant_domain + auth/users/routes + permi…

a0cbc8f

…ssions/models

vercel Bot deployed to Preview May 29, 2026 15:02 View deployment

Migrate sessions/service.revoke + conversions/routes path types

8315962

vercel Bot deployed to Preview May 29, 2026 15:05 View deployment

Migrate affiliates credential service methods to typed Ids

04d119c

vercel Bot deployed to Preview May 29, 2026 15:11 View deployment

Migrate auth/users service: delete + create_tenant_with_verified_owne…

0c822b0

…r typed

vercel Bot deployed to Preview May 29, 2026 15:14 View deployment

Middleware validate_api_key returns typed (TenantId, SecretKeyId)

ba7d5f1

vercel Bot deployed to Preview May 29, 2026 15:17 View deployment

Migrate stripe_webhook helpers to TenantId

4b77569

vercel Bot deployed to Preview May 29, 2026 15:20 View deployment

Migrate secret_keys service to typed TenantId/UserId/SecretKeyId

a19b56d

vercel Bot deployed to Preview May 29, 2026 15:26 View deployment

Migrate QuotaChecker trait to typed TenantId

b5546e7

vercel Bot deployed to Preview May 29, 2026 15:33 View deployment

Migrate conversions service to typed TenantId/SourceId

78245a7

vercel Bot deployed to Preview May 29, 2026 15:38 View deployment

Migrate TierResolver trait + BillingService to typed TenantId

d656f9f

vercel Bot deployed to Preview May 29, 2026 15:41 View deployment

Migrate links models (ClickMeta, AttributionEventMeta, CreateLinkInpu…

dc5b51a

…t) to typed IDs

vercel Bot deployed to Preview May 29, 2026 15:51 View deployment

Migrate links service to typed TenantId/AffiliateId — backlog drained…

95ae0a9

… to zero

vercel Bot deployed to Preview May 29, 2026 16:01 View deployment

Docs: update prefixed-ID examples in OpenAPI + CLAUDE.md/AGENTS.md

7470528

vercel Bot deployed to Preview May 29, 2026 16:24 View deployment

saltyskip merged commit 4a66684 into feat/public-id-foundation May 29, 2026
2 checks passed

saltyskip deleted the feat/public-id-rest branch May 29, 2026 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate remaining resources to typed Id<P> (#156)#175

Migrate remaining resources to typed Id<P> (#156)#175
saltyskip merged 24 commits into
feat/public-id-foundationfrom
feat/public-id-rest

saltyskip commented May 29, 2026

Uh oh!

vercel Bot commented May 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

saltyskip commented May 29, 2026

Summary

Resources migrated in this PR

New markers

Bridges to un-migrated layers

Remaining (38 files on the backlog)

Test plan

Uh oh!

vercel Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented May 29, 2026 •

edited

Loading