Skip to content

PLASMA-7021: fix colors in tokens for plasma-giga components #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oki1oki wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

PLASMA-7021: fix colors in tokens for plasma-giga components #2683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
472b1f4
fix(plasma-giga): fix Badge config [PLASMA-7021]
oki1oki Apr 9, 2026
ad01e7a
fix(plasma-giga): fix Button config
oki1oki Apr 9, 2026
340878c
fix(plasma-giga): fix Checkbox config
oki1oki Apr 9, 2026
3277a1f
fix(plasma-giga): fix Chip config
oki1oki Apr 9, 2026
f35d28f
fix(plasma-giga): fix IconButton config
oki1oki Apr 9, 2026
1701a87
fix(plasma-giga): fix NumberInput config
oki1oki Apr 9, 2026
8185418
fix(plasma-giga): fix Radiobox config
oki1oki Apr 9, 2026
231cbf2
fix(plasma-giga): fix SegmentItem config
oki1oki Apr 9, 2026
0e210ee
fix(plasma-giga): fix Switch config
oki1oki Apr 9, 2026
97fc3ba
chore(cypress): update shapshots [PLASMA-7021]
oki1oki Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...lasma-giga Badge -- [PLASMA-T1358] Badge size=s, view=positive, pilled.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../Badge/plasma-giga Badge -- [PLASMA-T1359] Badge size=xs, view=warning.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ium/Badge/plasma-giga Badge -- [PLASMA-T1362] Badge size=s, view=light.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...kit/Switch/plasma-giga Switch -- [PLASMA-1924] Switch focused, checked.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t/Switch/plasma-giga Switch -- [PLASMA-1925] Switch focused, unchecked.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/plasma-giga/src/components/Badge/Badge.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const config = {
${badgeTokens.colorClear}: var(--text-primary);
`,
accent: css`
${badgeTokens.color}: var(--on-dark-text-primary);
${badgeTokens.color}: var(--inverse-text-primary);
${badgeTokens.background}: var(--surface-accent);

${badgeTokens.colorTransparent}: var(--text-accent);
Expand Down
8 changes: 4 additions & 4 deletions packages/plasma-giga/src/components/Button/Button.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ export const config = {
${buttonTokens.buttonColorActive}: var(--inverse-text-primary-active);
`,
accent: css`
${buttonTokens.buttonColor}: var(--on-dark-text-primary);
${buttonTokens.buttonTextColor}: var(--on-dark-text-primary);
${buttonTokens.buttonIconColor}: var(--on-dark-text-primary);
${buttonTokens.buttonValueColor}: var(--on-dark-text-secondary);
${buttonTokens.buttonColor}: var(--inverse-text-primary);
${buttonTokens.buttonTextColor}: var(--inverse-text-primary);
${buttonTokens.buttonIconColor}: var(--inverse-text-primary);
${buttonTokens.buttonValueColor}: var(--inverse-text-secondary);
${buttonTokens.buttonBackgroundColor}: var(--surface-accent);
${buttonTokens.buttonLoadingBackgroundColor}: var(${buttonTokens.buttonBackgroundColor});
${buttonTokens.buttonBackgroundColorHover}: var(--surface-accent-hover);
Expand Down
4 changes: 2 additions & 2 deletions packages/plasma-giga/src/components/Checkbox/Checkbox.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const config = {
view: {
accent: css`
${checkboxTokens.fillColor}: var(--text-accent);
${checkboxTokens.iconColor}: var(--on-dark-text-primary);
${checkboxTokens.iconColor}: var(--inverse-text-primary);
${checkboxTokens.labelColor}: var(--text-primary);
${checkboxTokens.descriptionColor}: var(--text-secondary);
${checkboxTokens.triggerBackgroundColor}: transparent;
Expand Down Expand Up @@ -141,7 +141,7 @@ export const config = {
`,
negative: css`
${checkboxTokens.fillColor}: var(--text-negative);
${checkboxTokens.iconColor}: var(--on-dark-text-primary);
${checkboxTokens.iconColor}: var(--inverse-text-primary);
${checkboxTokens.descriptionColor}: var(--text-secondary);
${checkboxTokens.triggerBackgroundColor}: transparent;
${checkboxTokens.triggerBorderColor}: var(--text-negative);
Expand Down
10 changes: 5 additions & 5 deletions packages/plasma-giga/src/components/Chip/Chip.config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@ export const config = {
${chipTokens.leftContentColor}: var(--text-primary);
`,
accent: css`
${chipTokens.color}: var(--on-dark-text-primary);
${chipTokens.color}: var(--inverse-text-primary);
${chipTokens.background}: var(--surface-accent);
${chipTokens.colorHover}: var(--on-dark-text-primary);
${chipTokens.colorHover}: var(--inverse-text-primary);
${chipTokens.backgroundHover}: var(--surface-accent-hover);
${chipTokens.colorActive}: var(--on-dark-text-primary);
${chipTokens.colorActive}: var(--inverse-text-primary);
${chipTokens.backgroundActive}: var(--surface-accent-active);
${chipTokens.backgroundReadOnly}: var(--surface-accent);
${chipTokens.colorReadOnly}: var(--on-dark-text-primary);
${chipTokens.colorReadOnly}: var(--inverse-text-primary);
${chipTokens.backgroundReadOnlyHover}: var(--surface-accent);
${chipTokens.colorReadOnlyHover}: var(--on-dark-text-primary);
${chipTokens.colorReadOnlyHover}: var(--inverse-text-primary);

${chipTokens.closeIconColor}: var(--inverse-text-secondary);
${chipTokens.leftContentColor}: var(--inverse-text-primary);
Expand Down
2 changes: 1 addition & 1 deletion packages/plasma-giga/src/components/IconButton/IconButton.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const config = {
${iconButtonTokens.iconButtonColorActive}: var(--inverse-text-primary-active);
`,
accent: css`
${iconButtonTokens.iconButtonColor}: var(--on-dark-text-primary);
${iconButtonTokens.iconButtonColor}: var(--inverse-text-primary);
${iconButtonTokens.iconButtonBackgroundColor}: var(--surface-accent);
${iconButtonTokens.iconButtonLoadingBackgroundColor}: var(${iconButtonTokens.iconButtonBackgroundColor});
${iconButtonTokens.iconButtonBackgroundColorHover}: var(--surface-accent-hover);
Expand Down
12 changes: 6 additions & 6 deletions packages/plasma-giga/src/components/NumberInput/NumberInput.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,20 @@ export const config = {
${tokens.backgroundErrorColor}: var(--surface-transparent-negative);

${tokens.color}: var(--text-primary);
${tokens.colorSolid}: var(--on-dark-text-primary);
${tokens.colorSolid}: var(--inverse-text-primary);
${tokens.additionalTextColor}: var(--text-tertiary);
${tokens.additionalTextColorSolid}: var(--on-dark-text-tertiary);
${tokens.additionalTextColorSolid}: var(--inverse-text-tertiary);
${tokens.backgroundColorFocus}: var(--surface-transparent-secondary);
${tokens.backgroundColorSolidFocus}: var(--on-dark-surface-transparent-secondary);
${tokens.backgroundColorSolidFocus}: var(--inverse-surface-transparent-secondary);
${tokens.backgroundColorSolid}: var(--surface-accent);

${tokens.iconButtonColor}: var(--on-dark-text-primary);
${tokens.iconButtonColor}: var(--inverse-text-primary);
${tokens.iconButtonBackgroundColor}: var(--surface-accent);
${tokens.iconButtonColorHover}: var(--inverse-text-primary);
${tokens.iconButtonColorSolidHover}: var(--on-dark-text-primary-hover);
${tokens.iconButtonColorSolidHover}: var(--inverse-text-primary-hover);
${tokens.iconButtonBackgroundColorHover}: var(--surface-accent-hover);
${tokens.iconButtonColorActive}: var(--inverse-text-primary);
${tokens.iconButtonColorSolidActive}: var(--on-dark-text-primary-active);
${tokens.iconButtonColorSolidActive}: var(--inverse-text-primary-active);
${tokens.iconButtonBackgroundColorActive}: var(--surface-accent-active);

${tokens.actionButtonDisabledOpacity}: 0.4;
Expand Down
2 changes: 1 addition & 1 deletion packages/plasma-giga/src/components/Radiobox/Radiobox.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export const config = {
view: {
accent: css`
${radioboxTokens.fillColor}: var(--text-accent);
${radioboxTokens.ellipseColor}: var(--on-dark-text-primary);
${radioboxTokens.ellipseColor}: var(--inverse-text-primary);
${radioboxTokens.descriptionColor}: var(--text-secondary);
${radioboxTokens.triggerBackgroundColor}: transparent;
${radioboxTokens.triggerBorderColor}: var(--text-secondary);
Expand Down
8 changes: 4 additions & 4 deletions packages/plasma-giga/src/components/Segment/SegmentItem.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ export const config = {
${segmentTokens.itemBackgroundColorHover}: transparent;
${segmentTokens.itemAdditionalColor}: var(--text-secondary);
${segmentTokens.itemAdditionalColorHover}: var(--text-secondary);
${segmentTokens.itemSelectedColor}: var(--on-dark-text-primary);
${segmentTokens.itemSelectedColor}: var(--inverse-text-primary);
${segmentTokens.itemSelectedBackgroundColor}: var(--surface-accent);
${segmentTokens.itemSelectedColorHover}: var(--on-dark-text-primary-hover);
${segmentTokens.itemSelectedColorHover}: var(--inverse-text-primary-hover);
${segmentTokens.itemSelectedBackgroundColorHover}: var(--surface-accent);
${segmentTokens.itemSelectedAdditionalColor}: var(--on-dark-text-secondary);
${segmentTokens.itemSelectedAdditionalColorHover}: var(--on-dark-text-secondary);
${segmentTokens.itemSelectedAdditionalColor}: var(--inverse-text-secondary);
${segmentTokens.itemSelectedAdditionalColorHover}: var(--inverse-text-secondary);

${segmentTokens.groupFilledBackgroundColor}: var(--text-accent);
`,
Expand Down
2 changes: 1 addition & 1 deletion packages/plasma-giga/src/components/Switch/Switch.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const config = {
${switchTokens.trackBackgroundColorOffHover}: var(--surface-transparent-tertiary-hover);
${switchTokens.trackBorderWidthOn}: 0;
${switchTokens.trackBorderWidthOff}: 0;
${switchTokens.thumbBackgroundColorOn}: var(--on-dark-surface-solid-default);
${switchTokens.thumbBackgroundColorOn}: var(--inverse-surface-solid-default);
${switchTokens.thumbBackgroundColorOff}: var(--on-dark-surface-solid-default);
${switchTokens.thumbBoxShadow}: 0 1px 1px rgba(0, 0, 0, 0.11);
`,
Expand Down
Loading