PLASMA-7251: fix types in Button by shuga2704 · Pull Request #2776 · salute-developers/plasma

shuga2704 · 2026-05-15T10:56:15Z

Core

Button

исправлен баг в типизации компонента, при котором нельзя было создавать кастомные типы на основе <ComponentProps<typeof Button>>;

What/why changed

Причина поломки в неправильной типизации `MakePolymorphic`, изза которой `Omit/Pick` неправильно работает с дженериками, а именно с `callable generic signature`.

Также отключен vitest из-за ненадежности.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.376.0-canary.2776.26155511378.0
npm install @salutejs/plasma-b2c@1.618.0-canary.2776.26155511378.0
npm install @salutejs/plasma-core@1.226.0-canary.2776.26155511378.0
npm install @salutejs/plasma-giga@0.345.0-canary.2776.26155511378.0
npm install @salutejs/plasma-homeds@0.345.0-canary.2776.26155511378.0
npm install @salutejs/plasma-hope@1.372.0-canary.2776.26155511378.0
npm install @salutejs/plasma-icons@1.238.0-canary.2776.26155511378.0
npm install @salutejs/plasma-new-hope@0.362.0-canary.2776.26155511378.0
npm install @salutejs/plasma-tokens@1.138.0-canary.2776.26155511378.0
npm install @salutejs/plasma-ui@1.348.0-canary.2776.26155511378.0
npm install @salutejs/plasma-web@1.620.0-canary.2776.26155511378.0
npm install @salutejs/sdds-bizcom@0.350.0-canary.2776.26155511378.0
npm install @salutejs/sdds-cs@0.354.0-canary.2776.26155511378.0
npm install @salutejs/sdds-dfa@0.348.0-canary.2776.26155511378.0
npm install @salutejs/sdds-finai@0.341.0-canary.2776.26155511378.0
npm install @salutejs/sdds-insol@0.345.0-canary.2776.26155511378.0
npm install @salutejs/sdds-netology@0.349.0-canary.2776.26155511378.0
npm install @salutejs/sdds-os@0.20.0-canary.2776.26155511378.0
npm install @salutejs/sdds-platform-ai@0.349.0-canary.2776.26155511378.0
npm install @salutejs/sdds-sbcom@0.350.0-canary.2776.26155511378.0
npm install @salutejs/sdds-scan@0.348.0-canary.2776.26155511378.0
npm install @salutejs/sdds-serv@0.349.0-canary.2776.26155511378.0
npm install @salutejs/core-themes@0.30.0-canary.2776.26155511378.0
npm install @salutejs/plasma-themes@0.50.0-canary.2776.26155511378.0
npm install @salutejs/sdds-themes@0.65.0-canary.2776.26155511378.0
npm install @salutejs/sdds-api-tests@0.7.0-canary.2776.26155511378.0
npm install @salutejs/plasma-cy-utils@0.156.0-canary.2776.26155511378.0
npm install @salutejs/plasma-sb-utils@0.226.0-canary.2776.26155511378.0
# or 
yarn add @salutejs/plasma-asdk@0.376.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-b2c@1.618.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-core@1.226.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-giga@0.345.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-homeds@0.345.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-hope@1.372.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-icons@1.238.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-new-hope@0.362.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-tokens@1.138.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-ui@1.348.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-web@1.620.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-bizcom@0.350.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-cs@0.354.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-dfa@0.348.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-finai@0.341.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-insol@0.345.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-netology@0.349.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-os@0.20.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-platform-ai@0.349.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-sbcom@0.350.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-scan@0.348.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-serv@0.349.0-canary.2776.26155511378.0
yarn add @salutejs/core-themes@0.30.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-themes@0.50.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-themes@0.65.0-canary.2776.26155511378.0
yarn add @salutejs/sdds-api-tests@0.7.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-cy-utils@0.156.0-canary.2776.26155511378.0
yarn add @salutejs/plasma-sb-utils@0.226.0-canary.2776.26155511378.0

github-actions · 2026-05-15T10:58:48Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2776/

github-actions · 2026-05-15T11:52:35Z

Documentation preview deployed!

github-actions · 2026-05-27T10:13:31Z

This PR is included in version:

@salutejs/plasma-asdk@0.377.0
@salutejs/plasma-b2c@1.619.0
@salutejs/plasma-core@1.227.0
@salutejs/plasma-giga@0.346.0
@salutejs/plasma-homeds@0.346.0
@salutejs/plasma-hope@1.373.0
@salutejs/plasma-icons@1.238.0
@salutejs/plasma-new-hope@0.363.0
@salutejs/plasma-tokens-b2b@1.55.0
@salutejs/plasma-tokens-b2c@0.66.0
@salutejs/plasma-tokens-web@1.70.0
@salutejs/plasma-tokens@1.139.0
@salutejs/plasma-typo@0.43.0
@salutejs/plasma-ui@1.349.0
@salutejs/plasma-web@1.621.0
@salutejs/sdds-bizcom@0.351.0
@salutejs/sdds-cs@0.355.0
@salutejs/sdds-dfa@0.349.0
@salutejs/sdds-finai@0.342.0
@salutejs/sdds-insol@0.346.0
@salutejs/sdds-netology@0.350.0
@salutejs/sdds-os@0.21.0
@salutejs/sdds-platform-ai@0.350.0
@salutejs/sdds-sbcom@0.351.0
@salutejs/sdds-scan@0.349.0
@salutejs/sdds-serv@0.350.0
@salutejs/core-themes@0.30.0
@salutejs/plasma-themes@0.51.0
@salutejs/sdds-themes@0.66.0
@salutejs/sdds-api-tests@0.8.0
@salutejs/plasma-cy-utils@0.157.0
@salutejs/plasma-sb-utils@0.227.0
@salutejs/plasma-tokens-utils@0.51.0

shuga2704 self-assigned this May 15, 2026

shuga2704 temporarily deployed to internal May 15, 2026 10:56 — with GitHub Actions Inactive

shuga2704 marked this pull request as ready for review May 15, 2026 10:56

shuga2704 requested review from TitanKuzmich, Yakutoc, Yeti-or and neretin-trike as code owners May 15, 2026 10:56

github-actions Bot removed request for TitanKuzmich, Yakutoc, Yeti-or and neretin-trike May 15, 2026 10:57

shuga2704 requested review from TitanKuzmich, Yakutoc and neretin-trike May 15, 2026 10:58

TitanKuzmich approved these changes May 15, 2026

View reviewed changes

Yakutoc approved these changes May 18, 2026

View reviewed changes

shuga2704 had a problem deploying to internal May 20, 2026 09:25 — with GitHub Actions Error

feat(): fix types in Button

8397b46

shuga2704 force-pushed the plasma-7251 branch from ca27947 to bca690b Compare May 20, 2026 09:25

shuga2704 temporarily deployed to internal May 20, 2026 09:25 — with GitHub Actions Inactive

shuga2704 requested a review from oki1oki May 20, 2026 09:28

shuga2704 temporarily deployed to internal May 20, 2026 09:28 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 09:37 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 09:38 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 09:46 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 09:47 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7251 branch from 3a422eb to f47a175 Compare May 20, 2026 09:49

shuga2704 temporarily deployed to internal May 20, 2026 09:49 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 09:50 — with GitHub Actions Inactive

shuga2704 requested review from TitanKuzmich and Yakutoc May 20, 2026 09:54

Yakutoc reviewed May 20, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/types/Polymorphic.ts

Yakutoc reviewed May 20, 2026

View reviewed changes

Comment thread utils/api-tests/script.mjs

Yakutoc reviewed May 20, 2026

View reviewed changes

Comment thread utils/api-tests/package.json

feat(): remove Vitest tests

4d3d2fc

shuga2704 force-pushed the plasma-7251 branch from f47a175 to 4d3d2fc Compare May 20, 2026 10:02

shuga2704 temporarily deployed to internal May 20, 2026 10:02 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 10:03 — with GitHub Actions Inactive

neretin-trike approved these changes May 20, 2026

View reviewed changes

oki1oki approved these changes May 20, 2026

View reviewed changes

TitanKuzmich approved these changes May 20, 2026

View reviewed changes

Yakutoc approved these changes May 20, 2026

View reviewed changes

shuga2704 added this pull request to the merge queue May 20, 2026

Merged via the queue into dev with commit 9c25d39 May 20, 2026
72 of 77 checks passed

shuga2704 deleted the plasma-7251 branch May 20, 2026 17:37

Salute-Eva mentioned this pull request May 26, 2026

Release by 27.05.2026 #2808

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLASMA-7251: fix types in Button#2776

PLASMA-7251: fix types in Button#2776
shuga2704 merged 2 commits into
devfrom
plasma-7251

shuga2704 commented May 15, 2026 •

edited by Salute-Eva

Loading

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

shuga2704 commented May 15, 2026 • edited by Salute-Eva Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core

Button

What/why changed

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shuga2704 commented May 15, 2026 •

edited by Salute-Eva

Loading