PLASMA-7103: refactoring Combobox by shuga2704 · Pull Request #2789 · salute-developers/plasma

shuga2704 · 2026-05-20T14:05:50Z

Core

Combobox

проведён рефакторинг Combobox: основная логика состояния, выбора, фильтрации, навигации и работы со списком вынесена в отдельные hooks/utils;
удалены старые deprecated-свойства: listHeight и listOverflow;

What/why changed

проведён рефакторинг Combobox: основная логика состояния, выбора, фильтрации, навигации и работы со списком вынесена в отдельные hooks/utils;
старые comboboxNew* config/tokens переименованы и подключаются как combobox*;
унифицированы stories для Combobox: общие сценарии вынесены в plasma-sb-utils;
обновлены API-тесты Combobox, включая типизацию items, onChange, controlled/uncontrolled сценарии, react-hook-form, virtual list и infinite loading;
актуализирована документация;

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.376.0-canary.2789.26402381170.0
npm install @salutejs/plasma-b2c@1.618.0-canary.2789.26402381170.0
npm install @salutejs/plasma-core@1.226.0-canary.2789.26402381170.0
npm install @salutejs/plasma-giga@0.345.0-canary.2789.26402381170.0
npm install @salutejs/plasma-homeds@0.345.0-canary.2789.26402381170.0
npm install @salutejs/plasma-hope@1.372.0-canary.2789.26402381170.0
npm install @salutejs/plasma-icons@1.238.0-canary.2789.26402381170.0
npm install @salutejs/plasma-new-hope@0.362.0-canary.2789.26402381170.0
npm install @salutejs/plasma-tokens-b2b@1.55.0-canary.2789.26402381170.0
npm install @salutejs/plasma-tokens-b2c@0.66.0-canary.2789.26402381170.0
npm install @salutejs/plasma-tokens-web@1.70.0-canary.2789.26402381170.0
npm install @salutejs/plasma-tokens@1.138.0-canary.2789.26402381170.0
npm install @salutejs/plasma-typo@0.43.0-canary.2789.26402381170.0
npm install @salutejs/plasma-ui@1.348.0-canary.2789.26402381170.0
npm install @salutejs/plasma-web@1.620.0-canary.2789.26402381170.0
npm install @salutejs/sdds-bizcom@0.350.0-canary.2789.26402381170.0
npm install @salutejs/sdds-cs@0.354.0-canary.2789.26402381170.0
npm install @salutejs/sdds-dfa@0.348.0-canary.2789.26402381170.0
npm install @salutejs/sdds-finai@0.341.0-canary.2789.26402381170.0
npm install @salutejs/sdds-insol@0.345.0-canary.2789.26402381170.0
npm install @salutejs/sdds-netology@0.349.0-canary.2789.26402381170.0
npm install @salutejs/sdds-os@0.20.0-canary.2789.26402381170.0
npm install @salutejs/sdds-platform-ai@0.349.0-canary.2789.26402381170.0
npm install @salutejs/sdds-sbcom@0.350.0-canary.2789.26402381170.0
npm install @salutejs/sdds-scan@0.348.0-canary.2789.26402381170.0
npm install @salutejs/sdds-serv@0.349.0-canary.2789.26402381170.0
npm install @salutejs/core-themes@0.30.0-canary.2789.26402381170.0
npm install @salutejs/plasma-themes@0.50.0-canary.2789.26402381170.0
npm install @salutejs/sdds-themes@0.65.0-canary.2789.26402381170.0
npm install @salutejs/sdds-api-tests@0.7.0-canary.2789.26402381170.0
npm install @salutejs/plasma-cy-utils@0.156.0-canary.2789.26402381170.0
npm install @salutejs/plasma-sb-utils@0.226.0-canary.2789.26402381170.0
npm install @salutejs/plasma-tokens-utils@0.51.0-canary.2789.26402381170.0
# or 
yarn add @salutejs/plasma-asdk@0.376.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-b2c@1.618.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-core@1.226.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-giga@0.345.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-homeds@0.345.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-hope@1.372.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-icons@1.238.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-new-hope@0.362.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-tokens-b2b@1.55.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-tokens-b2c@0.66.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-tokens-web@1.70.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-tokens@1.138.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-typo@0.43.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-ui@1.348.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-web@1.620.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-bizcom@0.350.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-cs@0.354.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-dfa@0.348.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-finai@0.341.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-insol@0.345.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-netology@0.349.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-os@0.20.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-platform-ai@0.349.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-sbcom@0.350.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-scan@0.348.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-serv@0.349.0-canary.2789.26402381170.0
yarn add @salutejs/core-themes@0.30.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-themes@0.50.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-themes@0.65.0-canary.2789.26402381170.0
yarn add @salutejs/sdds-api-tests@0.7.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-cy-utils@0.156.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-sb-utils@0.226.0-canary.2789.26402381170.0
yarn add @salutejs/plasma-tokens-utils@0.51.0-canary.2789.26402381170.0

github-actions · 2026-05-20T14:08:36Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2789/

github-actions · 2026-05-20T14:27:41Z

Documentation preview deployed!

github-actions · 2026-05-27T10:13:40Z

This PR is included in version:

@salutejs/plasma-asdk@0.377.0
@salutejs/plasma-b2c@1.619.0
@salutejs/plasma-core@1.227.0
@salutejs/plasma-giga@0.346.0
@salutejs/plasma-homeds@0.346.0
@salutejs/plasma-hope@1.373.0
@salutejs/plasma-icons@1.238.0
@salutejs/plasma-new-hope@0.363.0
@salutejs/plasma-tokens-b2b@1.55.0
@salutejs/plasma-tokens-b2c@0.66.0
@salutejs/plasma-tokens-web@1.70.0
@salutejs/plasma-tokens@1.139.0
@salutejs/plasma-typo@0.43.0
@salutejs/plasma-ui@1.349.0
@salutejs/plasma-web@1.621.0
@salutejs/sdds-bizcom@0.351.0
@salutejs/sdds-cs@0.355.0
@salutejs/sdds-dfa@0.349.0
@salutejs/sdds-finai@0.342.0
@salutejs/sdds-insol@0.346.0
@salutejs/sdds-netology@0.350.0
@salutejs/sdds-os@0.21.0
@salutejs/sdds-platform-ai@0.350.0
@salutejs/sdds-sbcom@0.351.0
@salutejs/sdds-scan@0.349.0
@salutejs/sdds-serv@0.350.0
@salutejs/core-themes@0.30.0
@salutejs/plasma-themes@0.51.0
@salutejs/sdds-themes@0.66.0
@salutejs/sdds-api-tests@0.8.0
@salutejs/plasma-cy-utils@0.157.0
@salutejs/plasma-sb-utils@0.227.0
@salutejs/plasma-tokens-utils@0.51.0

shuga2704 self-assigned this May 20, 2026

shuga2704 temporarily deployed to internal May 20, 2026 14:06 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7103 branch from 016355d to 79ac104 Compare May 20, 2026 14:26

shuga2704 temporarily deployed to internal May 20, 2026 14:26 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 14:27 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 18:00 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 18:32 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 20, 2026 18:33 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 21, 2026 07:29 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7103 branch from ea7cfd2 to 8b74346 Compare May 21, 2026 08:12

shuga2704 temporarily deployed to internal May 21, 2026 08:12 — with GitHub Actions Inactive

shuga2704 had a problem deploying to internal May 21, 2026 12:04 — with GitHub Actions Error

shuga2704 force-pushed the plasma-7103 branch from d05a764 to ba37720 Compare May 21, 2026 12:04

shuga2704 temporarily deployed to internal May 21, 2026 12:04 — with GitHub Actions Inactive

TitanKuzmich reviewed May 25, 2026

View reviewed changes

Comment thread utils/plasma-sb-utils/src/components/Combobox/meta.ts

TitanKuzmich reviewed May 25, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/components/Combobox/hooks/useListState.ts Outdated

TitanKuzmich approved these changes May 25, 2026

View reviewed changes

IgorYar approved these changes May 25, 2026

View reviewed changes

shuga2704 added 4 commits May 25, 2026 13:01

feat(): update folder structure

8f823ed

feat(): refactoring Combobox

bf30dd0

feat(): refactor Combobox stories

4218f53

feat(): update Combobox docs

b43b8f5

shuga2704 force-pushed the plasma-7103 branch from f4eabad to b43b8f5 Compare May 25, 2026 10:01

shuga2704 temporarily deployed to internal May 25, 2026 10:01 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 25, 2026 10:17 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal May 25, 2026 10:18 — with GitHub Actions Inactive

neretin-trike reviewed May 25, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/components/Combobox/ui/Inner/ui/Item/Item.types.ts Outdated

neretin-trike reviewed May 25, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/components/Combobox/ui/ItemView/ItemView.tsx

neretin-trike reviewed May 25, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/components/Combobox/Combobox.tokens.ts

neretin-trike approved these changes May 25, 2026

View reviewed changes

feat(): code-review updates

9080179

shuga2704 force-pushed the plasma-7103 branch from 8cb8ac3 to 9080179 Compare May 25, 2026 13:14

shuga2704 temporarily deployed to internal May 25, 2026 13:14 — with GitHub Actions Inactive

shuga2704 added this pull request to the merge queue May 25, 2026

Merged via the queue into dev with commit 8efec7b May 25, 2026
58 checks passed

shuga2704 deleted the plasma-7103 branch May 25, 2026 15:58

Salute-Eva mentioned this pull request May 26, 2026

Release by 27.05.2026 #2808

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLASMA-7103: refactoring Combobox#2789

PLASMA-7103: refactoring Combobox#2789
shuga2704 merged 5 commits into
devfrom
plasma-7103

shuga2704 commented May 20, 2026 •

edited by Salute-Eva

Loading

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

shuga2704 commented May 20, 2026 • edited by Salute-Eva Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core

Combobox

What/why changed

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shuga2704 commented May 20, 2026 •

edited by Salute-Eva

Loading

github-actions Bot commented May 20, 2026 •

edited

Loading