Skip to content

Comments

fix use of arg in ltn12#1

Closed
catwell wants to merge 1 commit intosam-github:unstablefrom
catwell:unstable
Closed

fix use of arg in ltn12#1
catwell wants to merge 1 commit intosam-github:unstablefrom
catwell:unstable

Conversation

@catwell
Copy link

@catwell catwell commented Sep 17, 2012

arg is not part of Lua 5.1 and hence no longer works in Lua 5.2 or LuaJIT with its default compilation options.

Note that arg is apparently used in other parts of the codebase, but I have only hit this issue in ltn12 so far. If you think this fix is correct I can git a try at hunting use of arg in other places.

@sam-github
Copy link
Owner

Can you make patch against Diego's unstable tree, and send pull request to
him?

https://github.com/diegonehab/luasocket/tree/unstable

Thanks,
Sam

On Mon, Sep 17, 2012 at 9:33 AM, Pierre Chapuis notifications@github.comwrote:

arg is not part of Lua 5.1 and hence no longer works in Lua 5.2 or LuaJIT
with its default compilation options.

Note that arg is apparently used in other parts of the codebase, but I
have only hit this issue in ltn12 so far. If you think this fix is correct

I can git a try at hunting use of arg in other places.

You can merge this Pull Request by running:

git pull https://github.com/catwell/luasocket-1 unstable

Or view, comment on, or merge it at:

#1
Commit Summary

  • fix use of arg in ltn12

File Changes

  • M src/ltn12.lua (4)

Patch Links

@catwell
Copy link
Author

catwell commented Sep 17, 2012

Done (lunarmodules#24), closing here. Thanks for the pointer, I saw his empty master branch and thought development had moved here.

@catwell catwell closed this Sep 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants