Skip to content

Conversation

@samadh90
Copy link
Owner

Description

  1. SQLite connection isn't ready yet but will be in release. Need more work to do on it.
  2. Namespaces have been renamed cause of ambiguity with already existing ones.
  3. Connection class have been removed and IConnection renamed to IDevHopConnection for the same reason as in the point 2,
  4. Also DbType renamed to DatabaseType but not used anymore, will be removed in next release.

Fixes #2

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Have been tested localy and manually.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

samadh90 added 3 commits July 24, 2022 09:37
!! SQLite does not provide Stored Procedures. Need more work on SQLiteCo object.
- IConnection and DbType renamed,
- Connection removed.

BREAKING CHANGE: new approad of connection instantiation. Doc coming...
@samadh90 samadh90 added bug Something isn't working enhancement New feature or request labels Aug 26, 2022
@samadh90 samadh90 requested a review from aspirio187 August 26, 2022 20:25
@samadh90 samadh90 self-assigned this Aug 26, 2022
@samadh90 samadh90 merged commit 1ac9b1a into develop Aug 27, 2022
@samadh90 samadh90 deleted the feat/sqlite branch August 27, 2022 14:54
aspirio187 added a commit that referenced this pull request Aug 27, 2022
* Refactoring + LSP

* Feat/update templates (#3)

* Update feature_request.md

* Update bug_report.md

* Update pull_request.md

* Rename .github/ISSUE_TEMPLATE/pull_request.md to .github/pull_request_template.md

* Update issue templates

* Create CODE_OF_CONDUCT.md

* Create CONTRIBUTING.md

* feat!: sqlite (#5)

* SQLite Implementation

!! SQLite does not provide Stored Procedures. Need more work on SQLiteCo object.

* fix!: Namespaces & connectionString checks

- IConnection and DbType renamed,
- Connection removed.

BREAKING CHANGE: new approad of connection instantiation. Doc coming...

* Create build-and-test.pullrequest.yml (#7)

* Create build-and-test.pullrequest.yml

* Update build-and-test.pullrequest.yml

Co-authored-by: Aspirio <56565073+aspirio187@users.noreply.github.com>
@aspirio187 aspirio187 mentioned this pull request Aug 27, 2022
14 tasks
samadh90 added a commit that referenced this pull request Aug 27, 2022
* Refactoring + LSP

* Feat/update templates (#3)

* Update feature_request.md

* Update bug_report.md

* Update pull_request.md

* Rename .github/ISSUE_TEMPLATE/pull_request.md to .github/pull_request_template.md

* Update issue templates

* Create CODE_OF_CONDUCT.md

* Create CONTRIBUTING.md

* feat!: sqlite (#5)

* SQLite Implementation

!! SQLite does not provide Stored Procedures. Need more work on SQLiteCo object.

* fix!: Namespaces & connectionString checks

- IConnection and DbType renamed,
- Connection removed.

BREAKING CHANGE: new approad of connection instantiation. Doc coming...

* Create build-and-test.pullrequest.yml (#7)

* Create build-and-test.pullrequest.yml

* Update build-and-test.pullrequest.yml

Co-authored-by: Aspirio <56565073+aspirio187@users.noreply.github.com>

Co-authored-by: Samad Hatsijev <32033245+crysis90war@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] SQLite feature

3 participants